Add support for binary/octet-stream. #5892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quay.io responds with binary/octet-stream when reading imageBlob. application/octet-stream is identical to binary/octet-stream. Fixes spring-cloud#5885
corneil
force-pushed
the
main
branch
2 times, most recently
from
c0462f2
to
f0fb797
Compare
onobc
requested changes
Aug 20, 2024
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Show resolved
Hide resolved
| @@ -210,6 +210,7 @@ private RestTemplate initRestTemplate(HttpClientBuilder clientBuilder, boolean w | |||
| ArrayList<MediaType> mediaTypeList = new ArrayList(octetSupportJsonConverter.getSupportedMediaTypes()); | |||
| mediaTypeList.add(MediaType.APPLICATION_OCTET_STREAM); | |||
| mediaTypeList.add(MediaType.TEXT_PLAIN); | |||
| mediaTypeList.add(MediaType.parseMediaType("binary/octet-stream")); // quay.io responds with binary/octet-stream instead of application/octet-stream | |||
There was a problem hiding this comment.
I think it would be a good idea to ensure we have test coverage for this case.
There was a problem hiding this comment.
That can only be added with integration test using a quay.io container. We don't have existing integration tests for any of the registries.
There was a problem hiding this comment.
In that case a manual test will suffice. But let's be sure we do the manual test.
There was a problem hiding this comment.
@corneil if you can confirm this I will approve and merge this. Thanks.
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quay.io responds with binary/octet-stream when reading imageBlob.
application/octet-stream is identical to binary/octet-stream.
Fixes #5885