Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during "Clean up all task/job executions" #5408

Closed
klopfdreh opened this issue Jul 21, 2023 · 3 comments
Closed

Error during "Clean up all task/job executions" #5408

klopfdreh opened this issue Jul 21, 2023 · 3 comments
Milestone

Comments

@klopfdreh
Copy link
Contributor

Description:
We have almost 7000 task executions in our history.

When I tried to use "Clean up all task/job executions" there was an error on client side with a lot of "undefined"

I reloaded the ui, but all task executions and job executions were still present. In the "Task execution" the button "Clean up task execution" was not showing up for each task execution when I pressed on the three dots.

Also there were a lot of logs

{"timestamp":"2023-07-21T07:24:13.005+0200","level":"WARN","thread":"https-jsse-nio-8443-exec-8","logger":"org.springframework.cloud.deployer.spi.kubernetes.KubernetesTaskLauncher","message":"Cannot delete job for task \"fortschreibung-tgl-task-m68n655vv3\" (reason: job does not exist)","context":"default"}

but I don't know if this affects the delete process.

Release versions:
Spring Cloud Data Flow Server 2.10.3
Spring Cloud Skipper: 2.9.3

Custom apps:
N/A

Steps to reproduce:
Create a loooot of task executions with batch jobs and clean them up.

Screenshots:
N/A

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 21, 2023
@klopfdreh
Copy link
Contributor Author

The "Clean up task execution" was missing because I didn't pressed at the three dots from the compose task. Other than that the issue of not being able to "Clean up all task/job executions" is still present.

Question regarding this: If the UI runs in a timeout - will the thread still be opened to proceed the call in the backend?

@cppwfs cppwfs added for/team-attention For team attention and removed status/need-triage Team needs to triage and take a first look labels Jul 27, 2023
@klopfdreh
Copy link
Contributor Author

klopfdreh commented Aug 1, 2023

We increased the request timeout of our gateway, but the UI still shows errors. Beside the solution I provided in the PR we currently try to figure out how to solve the issue in the meantime. I just tried to increase the tomcat connection timeout. (server.tomcat.connection-timeout) as this might lead to the errors at the UI if the request is canceled on serverside at 60 seconds (the default configuration of the tomcat in spring).
See:

@markpollack markpollack added this to the 2.11.0 milestone Aug 3, 2023
@klopfdreh
Copy link
Contributor Author

klopfdreh commented Aug 7, 2023

I also had a look into the AngularJS implementation and it seems that there needs to be a configuration for this timeout adjusted as well: https://stackoverflow.com/questions/45938931/default-and-specific-request-timeout - this post is rather old but I guess there should be something in Angular as well.

Edit: Maybe it would be nice to get the timeout configuration from the server within the request interceptor from server.tomcat.connection-timeout - for the first request which might not take long, the default time out could be used and for all other requests the received one.

@onobc onobc modified the milestones: 2.11.0, 2.11.x Sep 14, 2023
@onobc onobc modified the milestones: 2.11.x, 2.11.2 Oct 30, 2023
@onobc onobc closed this as completed in 79845a0 Nov 2, 2023
@onobc onobc removed the for/team-attention For team attention label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants