Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using pipe delimiter for composed functions a user can't update a stream #3538

Closed
cppwfs opened this issue Oct 3, 2019 · 4 comments
Closed
Labels
status/need-investigation Oh need to look under a hood type/bug Is a bug report

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Oct 3, 2019

For example if you set deployment properties as app.myhttp.spring.cloud.stream.function.definition=upper|suffix. But when you try to update the stream to something like app.myhttp.spring.cloud.stream.function.definition=upper|suffix|reverse, the parser fails stating that upper is not a valid application. The workaround is to use commas instead of pipes.

@cppwfs cppwfs added the type/bug Is a bug report label Oct 3, 2019
@sabbyanandan
Copy link
Contributor

There's the use of | and ; as delimiters. I wasn't aware of ,, however. Let's confirm the recommended approach that we want to promote in SCDF. cc:/ @olegz

@sabbyanandan sabbyanandan added the status/need-investigation Oh need to look under a hood label Oct 14, 2019
@olegz
Copy link
Contributor

olegz commented Jun 12, 2020

Yes, that is correct. Coma is another delimiter with the same meaning as pipe for precisely the cases where piper may not work (e.g., HTTP URi)

@dturanski
Copy link
Contributor

@olegz - You recently discouraged the use of , . SCSt currently replaces with |. Is this something that might go away?
Another alternative is to use single quotes on the definition. But that passes through to SCSt, and would also have to be handled.

@markpollack markpollack added this to the 2.10.0-M3 milestone Sep 22, 2022
@markpollack markpollack modified the milestones: 2.10.0-M3, 2.10.0-RC1 Oct 7, 2022
@markpollack markpollack modified the milestones: 2.10.0-RC1, 2.10.1 Oct 13, 2022
@markpollack markpollack modified the milestones: 2.10.1, Priority Backlog Jan 5, 2023
@cppwfs
Copy link
Contributor Author

cppwfs commented Nov 13, 2024

Retested and was unable to reproduce.

@cppwfs cppwfs closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-investigation Oh need to look under a hood type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

5 participants