Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

Orders - OrderPopulator missing documentation #201

Open
dustineichler opened this issue Jan 21, 2014 · 1 comment
Open

Orders - OrderPopulator missing documentation #201

dustineichler opened this issue Jan 21, 2014 · 1 comment

Comments

@dustineichler
Copy link

Searched and didn't see a ticket for this.

Relevant link below. This ticket is a placeholder while this page hasn't been updated.

http://guides.spreecommerce.com/developer/orders.html

@radar
Copy link
Contributor

radar commented Jan 22, 2014

Thanks @dustineichler. I investigated that today, and I think the OrderPopulator is severely more complex than it needs to be. It's only used in OrdersController#populate and that action gets its information from the _cart_form partial. That partial only passes through a variant_id and quantity.

I've got a commit on my master branch (radar/spree@9950ce8716318952817d9d34e6b0f114c64a4ff7) which does a huge simplification of that class. I will be updating the documentation on master appropriately, and removing the documentation from 2-1-x, as I think it's too confusing to be used publicly.

radar added a commit that referenced this issue Jan 24, 2014
Its implementation in Spree 2.1 is too confusing to be documented. People would be better off using order.contents.add(variant_id, quantity) and working off that.

Fixes #201
radar added a commit that referenced this issue Mar 20, 2014
Its implementation in Spree 2.1 is too confusing to be documented. People would be better off using order.contents.add(variant_id, quantity) and working off that.

Fixes #201
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants