Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

Explain best practices for forking core gem and adding new features #185

Open
Lordnibbler opened this issue Nov 23, 2013 · 7 comments
Open

Comments

@Lordnibbler
Copy link

It is currently unclear, after forking spree/spree, how to fire up a new application for testing/adding a new feature.

@radar suggested to

  1. Create a new application
  2. Add gem 'spree', :path => "<path to spree>" to Gemfile

Perhaps add this to the http://guides.spreecommerce.com/developer/contributing.html in a new section about bugfixes/adding new features.

@Senjai
Copy link
Contributor

Senjai commented Nov 25, 2013

This is not a spree issue. I'd like to say this kind of thing is covered in the rails guides, but I might be wrong. Anytime you want to use a local gem this is how you specify it in rails, whether that be spree or anything.

You could also just keep your own fork on github and gem 'spree', github: 'lordnibbler/spree', brach: 'my-branch'

@Senjai
Copy link
Contributor

Senjai commented Nov 25, 2013

Also feel free to submit a patch too!

@Lordnibbler
Copy link
Author

@Senjai I understand this is not a Spree issue. I recently submitted my first PR to add a feature to Spree and found it unclear from the documentation what the best practice was to follow for adding/debugging features. hould I generate a dummy app, and test my feature against that? Start a new rails app from scratch? How do I pick my "development" gem? Etc.

My feeling is, that although this is more Railsy info, that adding it will somewhat lower the barrier to entry to start adding/fixing features in spree.

@Senjai
Copy link
Contributor

Senjai commented Nov 26, 2013

Right, but in that case we should link to the appropriate rails guides instead of duplicating ourselves here.

@Lordnibbler
Copy link
Author

@Senjai I'm all for that -- is there a guide you suggest we link to?

@peterberkenbosch
Copy link
Member

I love the sandbox script. bundle exec rake sandbox will generate an app for you in the sandbox folder and you can play around with it.

@peterberkenbosch
Copy link
Member

Also, just working and clear specs do help as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants