Java 11 #569
Closed
Java 11 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2023 17:55
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
=========================================
Coverage 91.47% 91.47%
Complexity 243 243
=========================================
Files 26 26
Lines 927 927
Branches 67 67
=========================================
Hits 848 848
Misses 52 52
Partials 27 27 |
|
What is the motivation for dropping support for Java 8? Beam SDK, Dataflow, Flink, Spark, etc. still offer Java 8 support. Because of that I would expect DBeam to keep support Java 8 for a bit longer... |
|
Mainly following reasons:
I guess using JDK 11 in development and package library as Java 8 code is a way to combine usage of a supported JDK and widen possible interation space (not to exclude any applications still on Java 8)? |
|
Right. This project uses/requires Java 11 at build time. It builds targeting Java 8. So Java8 can be used at runtime. Closing this. If there are other takes on it feel free to open follow up PR.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using more modern Java JDK & runtime (8 => 11).
Checklist for PR author(s)
mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)