Interactions in when blocks are not preserved #1761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interactions in a when: block were not active after the following then: block, if the then: block contained an interactions. Now the SpecRewriter inserts a "freezeScope" after the moved interactions from then blocks. This let the MockController skip the scope and use the outer scope for the interactions from the when block code. This fixes spockframework#1759
AndreasTu
added a commit
to AndreasTu/spock
that referenced
this pull request
Aug 14, 2023
Created separate PR for that: spockframework#1761
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
============================================
+ Coverage 79.76% 79.77% +0.01%
- Complexity 4054 4062 +8
============================================
Files 425 425
Lines 12886 12903 +17
Branches 1622 1624 +2
============================================
+ Hits 10278 10294 +16
Misses 1999 1999
- Partials 609 610 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactions in a when: block were not active after the following then: block, if the then: block contained an interactions.
Now the SpecRewriter inserts a "freezeScope" after the moved interactions from then blocks.
This let the MockController skip the scope and use the outer scope for the interactions from the when block code.
This fixes #1759