Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for spock.util.concurrent classes #1058

Open
Vampire opened this issue Nov 27, 2019 · 2 comments
Open

Documentation for spock.util.concurrent classes #1058

Vampire opened this issue Nov 27, 2019 · 2 comments

Comments

@Vampire
Copy link
Member

Vampire commented Nov 27, 2019

The classes in package spock.util.concurrent are only briefly mentioned in the Changelog.
Please add documentation for them to the normal Userguide.

@MykolaBova
Copy link

Hi! Is this issue still actual?
If yes Can you provide some technical details what and how supposed to be improved?

@kriegaex
Copy link
Contributor

kriegaex commented Apr 25, 2023

This issue overlaps with the much older #633.

The delta is that the other one also mentions Hamcrest expect/closeTo. While the Spock manual does not need to copy the Hamcrest documentation, I think it would make sense to add a small example for how to use those parts which Spock has special support for. So far, they are only briefly mentioned in release notes. @thokari, would you like to add that to #1173, too? Or does it make more sense to open a separate PR for that? It might also depend on the reviewers' preferences.

Update: Oh, OK, there was just a new comment on the old PR. I thought the PR was more recent. It seems as if there are review issues. I have not looked into it at all, my bad. But at least I am aware of this issue now, kind of duplicating mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants