Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VIRTUAL_SERVICE_PREFIX to VIRTUAL_SERVICE_NAME_PREFIX #40

Open
harsimranmaan opened this issue Jul 16, 2021 · 0 comments
Open

Rename VIRTUAL_SERVICE_PREFIX to VIRTUAL_SERVICE_NAME_PREFIX #40

harsimranmaan opened this issue Jul 16, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@harsimranmaan
Copy link
Contributor

harsimranmaan commented Jul 16, 2021

While this change cannot be done without breaking existing consumers, it is still possible to alias and keep both of them around. Pointed out by @cf250024 in #39
Update all doc refs to VIRTUAL_SERVICE_NAME_PREFIX

@harsimranmaan harsimranmaan added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant