Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: .uccignore does not work if globalconfig is not present #1103

Open
wmazur-splunk opened this issue Mar 11, 2024 · 3 comments · May be fixed by #1156
Open

BUG: .uccignore does not work if globalconfig is not present #1103

wmazur-splunk opened this issue Mar 11, 2024 · 3 comments · May be fixed by #1156
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wmazur-splunk
Copy link

wmazur-splunk commented Mar 11, 2024 •
edited
Loading

build.js:
Files from .uccignore are removed before copying ^^

if os.path.isfile(config_path):
...
else 
.... (line 635)
    removed_list = _remove_listed_files(ignore_list)
    if removed_list:
        logger.info("Removed:\n{}".format("\n".join(removed_list)))
    utils.recursive_overwrite(source, os.path.join(output_directory, ta_name))
    logger.info("Copied package directory")
@wmazur-splunk
Copy link
Author

bonus: check how the application behaves if executed with path like: --source my/src
It is looking for .uccignore in my folder instead of the repo root

@artemrys artemrys transferred this issue from splunk/addonfactory-workflow-addon-release Mar 11, 2024
@artemrys
Copy link
Member

@wmazur-splunk are you trying to build a .conf-only add-on?

@wmazur-splunk
Copy link
Author

wmazur-splunk commented Mar 15, 2024 •
edited
Loading

No, it's a child app with dashboards (build with Splunk Dashboard Studio), number of REST endpoints, custom searches and macros

@artemrys artemrys added the good first issue Good for newcomers label Mar 15, 2024
@artemrys artemrys added the bug Something isn't working label Apr 11, 2024
@artemrys artemrys changed the title .uccignore does not work if globalconfig is not present BUG: .uccignore does not work if globalconfig is not present Apr 11, 2024
@wmazur-splunk wmazur-splunk linked a pull request Apr 22, 2024 that will close this issue
[DRAFT] Fix path to globalConfig (incorrect file was used) #1156
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DRAFT] Fix path to globalConfig (incorrect file was used) splunk/addonfactory-ucc-generator
2 participants
@artemrys @wmazur-splunk