From 1617b8b45bce8dbeaa8614d9f3453378691dfa9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Luis=20Leal=20Cardoso=20Junior?= Date: Tue, 22 Feb 2022 10:32:54 -0300 Subject: [PATCH] Fix Rubocop Style/HashSyntax: Use the new Ruby 1.9 hash syntax --- Rakefile | 2 +- Readme.md | 22 +++++++++++----------- spec/analytics_spec.rb | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Rakefile b/Rakefile index 6ce3d4d..5c4b046 100644 --- a/Rakefile +++ b/Rakefile @@ -4,4 +4,4 @@ require 'rspec/core/rake_task' RSpec::Core::RakeTask.new('spec') -task :default => :spec \ No newline at end of file +task default: :spec \ No newline at end of file diff --git a/Readme.md b/Readme.md index d08251f..3738820 100644 --- a/Readme.md +++ b/Readme.md @@ -17,7 +17,7 @@ The split gem and its dependencies. If you are using bundler add split to your Gemfile: ```ruby -gem 'split-analytics', :require => 'split/analytics' +gem 'split-analytics', require: 'split/analytics' ``` Then run: @@ -45,13 +45,13 @@ Use in your application layout template erb example: ```erb -<%= tracking_code(:account => 'UA-12345-6') %> +<%= tracking_code(account: 'UA-12345-6') %> ``` haml example: ```haml -= tracking_code(:account => 'UA-12345-6') += tracking_code(account: 'UA-12345-6') ``` ### With Tracking Methods @@ -60,23 +60,23 @@ See [Google Analytics Tracking Methods](https://developers.google.com/analytics/ ```ruby tracker_methods = { - :setDomainName => "example.com", # String argument - :setAllowLinker => true, # Boolean argument - :require => ['inpage_linkid', '//www.google-analytics.com/plugins/ga/inpage_linkid.js'] # Array argument (will be splattered) - :clearOrganic => "" # No argument + setDomainName: "example.com", # String argument + setAllowLinker: true, # Boolean argument + require: ['inpage_linkid', '//www.google-analytics.com/plugins/ga/inpage_linkid.js'] # Array argument (will be splattered) + clearOrganic: "" # No argument } ``` erb example: ```erb -<%= tracking_code(:account => 'UA-12345-6', :tracker_methods => tracker_methods) %> +<%= tracking_code(account: 'UA-12345-6', tracker_methods: tracker_methods) %> ``` haml example: ```haml -= tracking_code(:account => 'UA-12345-6', :tracker_methods => tracker_methods) += tracking_code(account: 'UA-12345-6', tracker_methods: tracker_methods) ``` ### Other Tracking URLs @@ -85,13 +85,13 @@ You can use other Tracking URLs with the option tracker_url and ssl_tracker_url. erb example: ```erb -<%= tracking_code(:account => 'UA-12345-6', :tracker_url => 'stats.g.doubleclick.net/dc.js', :ssl_tracker_url => 'stats.g.doubleclick.net/dc.js') %> +<%= tracking_code(account: 'UA-12345-6', tracker_url: 'stats.g.doubleclick.net/dc.js', ssl_tracker_url: 'stats.g.doubleclick.net/dc.js') %> ``` haml example: ```haml -= tracking_code(:account => 'UA-12345-6', :tracker_url => 'stats.g.doubleclick.net/dc.js', :ssl_tracker_url => 'stats.g.doubleclick.net/dc.js') += tracking_code(account: 'UA-12345-6', tracker_url: 'stats.g.doubleclick.net/dc.js', ssl_tracker_url: 'stats.g.doubleclick.net/dc.js') ``` ## Contributing diff --git a/spec/analytics_spec.rb b/spec/analytics_spec.rb index 2e50e91..23fb103 100644 --- a/spec/analytics_spec.rb +++ b/spec/analytics_spec.rb @@ -13,7 +13,7 @@ setAllowLinker: true, # Boolean argument clearOrganic: '' # No argument } - tracking_code = tracking_code(:account => 'UA-12345-6', :tracker_methods => tracker_methods) + tracking_code = tracking_code(account: 'UA-12345-6', tracker_methods: tracker_methods) expect(tracking_code).to eql(%Q{ \n}) end @@ -26,7 +26,7 @@ end it 'uses doubleclick as tracker url' do - tracking_code = tracking_code(account: "UA-12345-6", tracker_url: 'stats.g.doubleclick.net/dc.js', :ssl_tracker_url => 'stats.g.doubleclick.net/dc.js') + tracking_code = tracking_code(account: "UA-12345-6", tracker_url: 'stats.g.doubleclick.net/dc.js', ssl_tracker_url: 'stats.g.doubleclick.net/dc.js') expect(tracking_code).to eql(%Q{ \n}) end end