Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy method #8

Open
gregtatum opened this issue Aug 10, 2015 · 4 comments
Open

Destroy method #8

gregtatum opened this issue Aug 10, 2015 · 4 comments

Comments

@gregtatum
Copy link

Is there any way to destroy rStats after initing? I'm trying to integrate this into a multi-level environment, so I need to be able to take it apart. I'm not seeing anything in the code or docs.

@spite
Copy link
Owner

spite commented Aug 10, 2015

There isn't a method to do that, no. It's meant as a debug lib, so there wasn't too much worry to destroy anything created. It can be added, of course. Are you thinking on mostly on the DOM and event listeners, or also the instrumentation of WebGL/threejs/etc?

@gregtatum
Copy link
Author

I've started with implementing the .start() and .end() functions, and haven't gotten into the rest of the features. So right now it's more about the DOM elements. But ideally yes, it'd be great if everything was supported. I tear apart everything and rebuild it between, that way I can do different renderer configurations between levels.

@spite
Copy link
Owner

spite commented Aug 10, 2015

If you want to do a PR, I'll check the other methods. Although I'm wondering if this library could do with an overhaul. It's too verbose for my taste, even though there are not many other ways to track execution time...

@gregtatum
Copy link
Author

Yeah, I can do a PR. rStats would really be nice to have integrated in my
sandbox framework.

On Mon, Aug 10, 2015 at 11:56 AM Jaume Sanchez [email protected]
wrote:

If you want to do a PR, I'll check the other methods. Although I'm
wondering if this library could do with an overhaul. It's too verbose for
my taste, even though there are not many other ways to track execution
time...


Reply to this email directly or view it on GitHub
#8 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants