Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach chunked array to use canonical_into as the implementation of into_canonical #2356

Closed
danking opened this issue Feb 13, 2025 · 1 comment
Closed

Teach chunked array to use canonical_into as the implementation of into_canonical #2356

danking opened this issue Feb 13, 2025 · 1 comment
Assignees
@danking

Comments

@danking
Copy link
Member

danking commented Feb 13, 2025

In order to avoid performance degradation ensure:

  1. Benchmark with a diverse set of chunk encodings.
  2. Benchmark with from small to large numbers of rows per chunk.
  3. Benchmark from 1 to many chunks.
@danking danking self-assigned this Feb 13, 2025
@danking danking mentioned this issue Feb 13, 2025
Merged
@robert3005
Copy link
Member

done in #2511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danking danking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danking @robert3005