Skip to content

Commit e1f1ba3

Browse files
authored
ci: move compress & random_access benchs toruns-on (#2594)
Moves the `compress` & `random_access` benchmarks to`runs-on`.
1 parent 2c939fe commit e1f1ba3

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

.github/workflows/bench-pr.yml

+12-9
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ jobs:
2424

2525
bench:
2626
needs: label_trigger
27-
runs-on: [ self-hosted, gcp ]
27+
runs-on:
28+
- runs-on=${{ github.run_id }}
29+
- family=c7i.8xlarge
30+
- image=ubuntu24-full-x64
31+
- disk=large
2832
strategy:
2933
matrix:
3034
benchmark:
@@ -34,21 +38,16 @@ jobs:
3438
name: Compression
3539
if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }}
3640
steps:
41+
- uses: runs-on/action@v1
3742
- uses: actions/checkout@v4
38-
- uses: ./.github/actions/cleanup
39-
- uses: ./.github/actions/setup-rust
43+
# rustup is pre-installed on the ubuntu24-full-x64 image.
44+
4045
# The compression benchmarks rely on DuckDB being installed to convert CSV to Parquet
4146
- name: Install DuckDB
4247
uses: opt-nc/[email protected]
43-
if: runner.environment != 'self-hosted'
4448
with:
4549
version: v1.0.0
4650

47-
- name: Set tempdir
48-
if: runner.environment == 'self-hosted'
49-
run: |
50-
echo "TMPDIR=/work" >> $GITHUB_ENV
51-
5251
- name: Run ${{ matrix.benchmark.name }} benchmark
5352
shell: bash
5453
env:
@@ -61,8 +60,10 @@ jobs:
6160
with:
6261
role-to-assume: arn:aws:iam::375504701696:role/GitHubBenchmarkRole
6362
aws-region: us-east-1
63+
6464
- name: Install uv
6565
uses: astral-sh/setup-uv@v5
66+
6667
- name: Compare results
6768
shell: bash
6869
run: |
@@ -81,11 +82,13 @@ jobs:
8182
uv run scripts/compare-benchmark-jsons.py base.json ${{ matrix.benchmark.id }}.json \
8283
>> comment.md
8384
echo '</details>' >> comment.md
85+
8486
- name: Comment PR
8587
uses: thollander/actions-comment-pull-request@v3
8688
with:
8789
file-path: comment.md
8890
comment-tag: bench-pr-comment-${{ matrix.benchmark.id }}
91+
8992
sql:
9093
needs: label_trigger
9194
uses: ./.github/workflows/sql-benchmarks.yml

.github/workflows/bench.yml

+8-9
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ jobs:
3030
bash scripts/cat-s3.sh vortex-benchmark-results-database commits.json new-commit.json
3131
3232
bench:
33-
runs-on: [ self-hosted, gcp ]
33+
runs-on:
34+
- runs-on=${{ github.run_id }}
35+
- family=c7i.8xlarge
36+
- image=ubuntu24-full-x64
37+
- disk=large
3438
strategy:
3539
matrix:
3640
benchmark:
@@ -39,21 +43,16 @@ jobs:
3943
- id: compress
4044
name: Compression
4145
steps:
46+
- uses: runs-on/action@v1
4247
- uses: actions/checkout@v4
43-
- uses: ./.github/actions/cleanup
44-
- uses: ./.github/actions/setup-rust
48+
# rustup is pre-installed on the ubuntu24-full-x64 image.
49+
4550
# The compression benchmarks rely on DuckDB being installed to convert CSV to Parquet
4651
- name: Install DuckDB
4752
uses: opt-nc/[email protected]
48-
if: runner.environment != 'self-hosted'
4953
with:
5054
version: v1.0.0
5155

52-
- name: Set tempdir
53-
if: runner.environment == 'self-hosted'
54-
run: |
55-
echo "TMPDIR=/work" >> $GITHUB_ENV
56-
5756
- name: Run ${{ matrix.benchmark.name }} benchmark
5857
shell: bash
5958
env:

0 commit comments

Comments
 (0)