expose Array is_invalid over FFI

Author: a10y

java/vortex-jni/src/main/java/dev/vortex/impl/NativeArray.java

@@ -84,8 +84,8 @@ public Array slice(int start, int stop) {
 
     @Override
     public boolean getNull(int index) {
-        // check validity of the array
-        return false;
+        checkNotNull(inner, "inner");
+        return FFI.FFIArray_is_null(inner, index);
     }
 
     @Override

java/vortex-jni/src/main/java/dev/vortex/jni/FFI.java

@@ -37,6 +37,8 @@ public final class FFI {
 
     public static native FFIArray FFIArray_slice(FFIArray array, int start, int stop);
 
+    public static native boolean FFIArray_is_null(FFIArray array, int index);
+
     public static native FFIArray FFIArray_get_field(FFIArray array, int index);
 
     public static native byte FFIArray_get_u8(FFIArray array, int index);

java/vortex-jni/src/test/java/dev/vortex/jni/FFITest.java

@@ -15,20 +15,19 @@
  */
 package dev.vortex.spark.read;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.base.Preconditions.checkState;
+
 import dev.vortex.api.Array;
 import dev.vortex.api.ArrayStream;
 import dev.vortex.api.File;
 import dev.vortex.api.ScanOptions;
 import dev.vortex.impl.NativeFile;
 import dev.vortex.spark.VortexFilePartition;
+import java.util.Objects;
 import org.apache.spark.sql.connector.read.PartitionReader;
 import org.apache.spark.sql.vectorized.ColumnarBatch;
 
-import java.util.Objects;
-
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.base.Preconditions.checkState;
-
 /**
  * A {@link PartitionReader} that reads columnar batches out of a Vortex file into
  * Vortex memory format.

java/vortex-spark/src/main/java/dev/vortex/spark/read/VortexPartitionReader.java

@@ -19,8 +19,10 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import org.apache.spark.sql.SparkSession;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
+@Disabled
 final class VortexScanTest {
     private static final Path TPCH_ROOT = Paths.get("/Volumes/Code/vortex/bench-vortex/data/tpch/1/vortex_compressed");
 

java/vortex-spark/src/test/java/dev/vortex/spark/VortexScanTest.java

@@ -82,6 +82,15 @@ pub unsafe extern "C" fn FFIArray_slice(
     Box::into_raw(Box::new(FFIArray { inner: sliced }))
 }
 
+#[unsafe(no_mangle)]
+pub unsafe extern "C" fn FFIArray_is_null(array: *const FFIArray, index: u32) -> bool {
+    let array = &*array;
+    array
+        .inner
+        .is_invalid(index as usize)
+        .vortex_expect("FFIArray_is_null: is_invalid")
+}
+
 macro_rules! ffiarray_get_ptype {
     ($ptype:ident) => {
         paste::paste! {