Skip to content

Commit 91cf1f9

Browse files
committed
fixes
1 parent e9998b2 commit 91cf1f9

File tree

1 file changed

+1
-24
lines changed

1 file changed

+1
-24
lines changed

vortex-array/src/arrays/chunked/canonical.rs

+1-24
Original file line numberDiff line numberDiff line change
@@ -23,45 +23,22 @@ impl ArrayCanonicalImpl for ChunkedArray {
2323
mod tests {
2424
use std::sync::Arc;
2525

26-
use vortex_dtype::DType;
2726
use vortex_dtype::DType::{List, Primitive};
2827
use vortex_dtype::Nullability::NonNullable;
2928
use vortex_dtype::PType::I32;
3029

3130
use crate::ToCanonical;
3231
use crate::accessor::ArrayAccessor;
3332
use crate::array::Array;
34-
use crate::arrays::chunked::canonical::pack_views;
3533
use crate::arrays::{ChunkedArray, ListArray, PrimitiveArray, StructArray, VarBinViewArray};
36-
use crate::compute::{scalar_at, slice};
34+
use crate::compute::scalar_at;
3735
use crate::validity::Validity;
3836
use crate::variants::StructArrayTrait;
3937

4038
fn stringview_array() -> VarBinViewArray {
4139
VarBinViewArray::from_iter_str(["foo", "bar", "baz", "quak"])
4240
}
4341

44-
#[test]
45-
pub fn pack_sliced_varbin() {
46-
let array1 = slice(&stringview_array(), 1, 3).unwrap();
47-
let array2 = slice(&stringview_array(), 2, 4).unwrap();
48-
let packed = pack_views(
49-
&[array1, array2],
50-
&DType::Utf8(NonNullable),
51-
Validity::NonNullable,
52-
)
53-
.unwrap();
54-
assert_eq!(packed.len(), 4);
55-
let values = packed
56-
.with_iterator(|iter| {
57-
iter.flatten()
58-
.map(|v| unsafe { String::from_utf8_unchecked(v.to_vec()) })
59-
.collect::<Vec<_>>()
60-
})
61-
.unwrap();
62-
assert_eq!(values, &["bar", "baz", "baz", "quak"]);
63-
}
64-
6542
#[test]
6643
pub fn pack_nested_structs() {
6744
let struct_array = StructArray::try_new(

0 commit comments

Comments
 (0)