Skip to content

Commit 66efa9c

Browse files
authored
chore: Cleanup some unused dependencies (#2582)
While staring at too many builds today, noticed a bunch of crates we don't actually use. I think we should also consider stopping to release `vortex-proto` as it doesn't seem to be actually used right now, so we just keep building and releasing it again and again.
1 parent 019815a commit 66efa9c

File tree

12 files changed

+7
-33
lines changed

12 files changed

+7
-33
lines changed

Cargo.lock

-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bench-vortex/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ async-trait = { workspace = true }
3030
bytes = { workspace = true }
3131
bzip2 = { workspace = true }
3232
cfg-if = { workspace = true }
33-
chrono = { workspace = true, features = ["std"] }
3433
clap = { workspace = true, features = ["derive"] }
3534
datafusion = { workspace = true, features = [
3635
"parquet",

encodings/bytebool/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ workspace = true
1919
[dependencies]
2020
arrow-buffer = { workspace = true }
2121
num-traits = { workspace = true }
22-
serde = { workspace = true, features = ["derive"] }
2322
vortex-array = { workspace = true }
2423
vortex-buffer = { workspace = true }
2524
vortex-dtype = { workspace = true }

encodings/datetime-parts/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ workspace = true
1919
[dependencies]
2020
getrandom_v02 = { workspace = true }
2121
rkyv = { workspace = true }
22-
serde = { workspace = true, features = ["derive"] }
2322
vortex-array = { workspace = true }
2423
vortex-buffer = { workspace = true }
2524
vortex-datetime-dtype = { workspace = true }

encodings/dict/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ num-traits = { workspace = true }
2323
rand = { workspace = true, optional = true }
2424
rustc-hash = { workspace = true }
2525
rkyv = { workspace = true }
26-
serde = { workspace = true }
2726
vortex-array = { workspace = true }
2827
vortex-buffer = { workspace = true }
2928
vortex-dtype = { workspace = true }

vortex-dtype/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ flatbuffers = { workspace = true }
2424
half = { workspace = true, features = ["num-traits"] }
2525
itertools = { workspace = true }
2626
num-traits = { workspace = true }
27-
prost = { workspace = true, optional = true }
2827
rkyv = { workspace = true, optional = true, features = ["bytecheck"] }
2928
serde = { workspace = true, optional = true, features = ["rc", "derive"] }
3029
static_assertions = { workspace = true }
@@ -40,5 +39,5 @@ serde_test = { workspace = true }
4039
workspace = true
4140

4241
[features]
43-
proto = ["dep:prost", "vortex-proto/dtype"]
42+
proto = ["vortex-proto/dtype"]
4443
serde = ["dep:serde"]

vortex-dtype/src/serde/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
pub mod flatbuffers;
2+
23
#[cfg(feature = "proto")]
34
mod proto;
5+
46
#[allow(clippy::module_inception)]
57
mod serde;
68

vortex-expr/Cargo.toml

+1-7
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ datafusion-expr = { workspace = true, optional = true }
2626
datafusion-physical-expr = { workspace = true, optional = true }
2727
dyn-hash = { workspace = true }
2828
itertools = { workspace = true }
29-
prost = { workspace = true, optional = true }
3029
serde = { workspace = true, optional = true, features = ["derive"] }
3130
vortex-array = { workspace = true }
3231
vortex-buffer = { workspace = true }
@@ -44,11 +43,6 @@ datafusion = [
4443
"dep:datafusion-physical-expr",
4544
"vortex-scalar/datafusion",
4645
]
47-
proto = [
48-
"dep:prost",
49-
"vortex-dtype/proto",
50-
"vortex-scalar/proto",
51-
"vortex-proto/expr",
52-
]
5346
serde = ["dep:serde", "vortex-dtype/serde", "vortex-scalar/serde"]
47+
proto = ["vortex-dtype/proto", "vortex-scalar/proto", "vortex-proto/expr"]
5448
test-harness = []

vortex-file/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ vortex-array = { workspace = true }
3535
vortex-btrblocks = { workspace = true }
3636
vortex-buffer = { workspace = true }
3737
vortex-bytebool = { workspace = true }
38-
vortex-datetime-dtype = { workspace = true }
3938
vortex-datetime-parts = { workspace = true }
4039
vortex-dict = { workspace = true }
4140
vortex-dtype = { workspace = true }

vortex-layout/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ vortex-error = { workspace = true }
3737
vortex-expr = { workspace = true }
3838
vortex-flatbuffers = { workspace = true, features = ["layout"] }
3939
vortex-mask = { workspace = true }
40-
vortex-scalar = { workspace = true }
4140

4241
[dev-dependencies]
4342
futures = { workspace = true, features = ["executor"] }

vortex-scalar/Cargo.toml

+1-8
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ flexbuffers = { workspace = true, optional = true }
2222
itertools = { workspace = true }
2323
num-traits = { workspace = true }
2424
paste = { workspace = true }
25-
prost = { workspace = true, optional = true }
26-
prost-types = { workspace = true, optional = true }
2725
serde = { workspace = true, optional = true, features = ["rc"] }
2826
vortex-buffer = { workspace = true }
2927
vortex-datetime-dtype = { workspace = true }
@@ -53,10 +51,5 @@ flatbuffers = [
5351
"vortex-error/flatbuffers",
5452
"vortex-error/flexbuffers",
5553
]
56-
proto = [
57-
"dep:prost",
58-
"dep:prost-types",
59-
"vortex-dtype/proto",
60-
"vortex-proto/scalar",
61-
]
54+
proto = ["vortex-dtype/proto", "vortex-proto/scalar"]
6255
serde = ["dep:serde", "serde/derive", "vortex-dtype/serde"]

vortex-scalar/src/serde/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#[cfg(feature = "flatbuffers")]
22
mod flatbuffers;
3+
34
#[cfg(feature = "proto")]
45
mod proto;
6+
57
#[allow(clippy::module_inception)]
68
mod serde;

0 commit comments

Comments
 (0)