Skip to content

Commit 564b458

Browse files
authored
Deny dbg macro in code (#2440)
clippy will now forbid `dbg!` usage outside of tests (but `cargo run`/`cargo test` will work nicely as far as I can tell).
1 parent 56233d3 commit 564b458

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ cargo = { level = "deny", priority = -1 }
213213
cast_possible_truncation = "deny"
214214
collection_is_never_read = "deny"
215215
cognitive_complexity = "deny"
216+
dbg_macro = "deny"
216217
debug_assert_with_mut_call = "deny"
217218
derive_partial_eq_without_eq = "deny"
218219
exit = "deny"

clippy.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1+
allow-dbg-in-tests = true
12
allow-expect-in-tests = true
23
allow-unwrap-in-tests = true
34
single-char-binding-names-threshold = 2
4-
disallowed-types = [
5-
"std::collections::HashMap",
6-
"std::collections::HashSet",
7-
]
5+
disallowed-types = ["std::collections::HashMap", "std::collections::HashSet"]

vortex-datafusion/src/persistent/execution.rs

-2
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,6 @@ impl ExecutionPlan for VortexExec {
173173
.flatten()
174174
.collect::<Vec<_>>();
175175

176-
dbg!(&all_files[0].statistics);
177-
178176
let total_size = all_files.iter().map(|f| f.object_meta.size).sum::<usize>();
179177

180178
// If there's one file or less total files in the scan, we can't repartition it

0 commit comments

Comments
 (0)