-
Notifications
You must be signed in to change notification settings - Fork 34
/
Copy pathcompute.rs
236 lines (196 loc) · 7.36 KB
/
compute.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
use num_traits::AsPrimitive;
use vortex_array::compute::{FillForwardFn, MaskFn, ScalarAtFn, SliceFn, TakeFn};
use vortex_array::validity::Validity;
use vortex_array::variants::PrimitiveArrayTrait;
use vortex_array::vtable::ComputeVTable;
use vortex_array::{Array, ArrayComputeImpl, ArrayRef, ToCanonical};
use vortex_dtype::{Nullability, match_each_integer_ptype};
use vortex_error::{VortexResult, vortex_err};
use vortex_mask::Mask;
use vortex_scalar::Scalar;
use super::{ByteBoolArray, ByteBoolEncoding};
impl ArrayComputeImpl for ByteBoolArray {}
impl ComputeVTable for ByteBoolEncoding {
fn fill_forward_fn(&self) -> Option<&dyn FillForwardFn<&dyn Array>> {
None
}
fn mask_fn(&self) -> Option<&dyn MaskFn<&dyn Array>> {
Some(self)
}
fn scalar_at_fn(&self) -> Option<&dyn ScalarAtFn<&dyn Array>> {
Some(self)
}
fn slice_fn(&self) -> Option<&dyn SliceFn<&dyn Array>> {
Some(self)
}
fn take_fn(&self) -> Option<&dyn TakeFn<&dyn Array>> {
Some(self)
}
}
impl MaskFn<&ByteBoolArray> for ByteBoolEncoding {
fn mask(&self, array: &ByteBoolArray, mask: Mask) -> VortexResult<ArrayRef> {
Ok(ByteBoolArray::new(array.buffer().clone(), array.validity().mask(&mask)?).into_array())
}
}
impl ScalarAtFn<&ByteBoolArray> for ByteBoolEncoding {
fn scalar_at(&self, array: &ByteBoolArray, index: usize) -> VortexResult<Scalar> {
Ok(Scalar::bool(
array.buffer()[index] == 1,
array.dtype().nullability(),
))
}
}
impl SliceFn<&ByteBoolArray> for ByteBoolEncoding {
fn slice(&self, array: &ByteBoolArray, start: usize, stop: usize) -> VortexResult<ArrayRef> {
Ok(ByteBoolArray::new(
array.buffer().slice(start..stop),
array.validity().slice(start, stop)?,
)
.into_array())
}
}
impl TakeFn<&ByteBoolArray> for ByteBoolEncoding {
fn take(&self, array: &ByteBoolArray, indices: &dyn Array) -> VortexResult<ArrayRef> {
let validity = array.validity_mask()?;
let indices = indices.to_primitive()?;
let bools = array.as_slice();
// FIXME(ngates): we should be operating over canonical validity, which doesn't
// have fallible is_valid function.
let arr = match validity {
Mask::AllTrue(_) => {
let bools = match_each_integer_ptype!(indices.ptype(), |$I| {
indices.as_slice::<$I>()
.iter()
.map(|&idx| {
let idx: usize = idx.as_();
bools[idx]
})
.collect::<Vec<_>>()
});
ByteBoolArray::from(bools).into_array()
}
Mask::AllFalse(_) => ByteBoolArray::from(vec![None; indices.len()]).into_array(),
Mask::Values(values) => {
let bools = match_each_integer_ptype!(indices.ptype(), |$I| {
indices.as_slice::<$I>()
.iter()
.map(|&idx| {
let idx = idx.as_();
if values.value(idx) {
Some(bools[idx])
} else {
None
}
})
.collect::<Vec<Option<_>>>()
});
ByteBoolArray::from(bools).into_array()
}
};
Ok(arr)
}
}
impl FillForwardFn<&ByteBoolArray> for ByteBoolEncoding {
fn fill_forward(&self, array: &ByteBoolArray) -> VortexResult<ArrayRef> {
let validity = array.validity_mask()?;
if array.dtype().nullability() == Nullability::NonNullable {
return Ok(array.to_array().into_array());
}
// all valid, but we need to convert to non-nullable
if validity.all_true() {
return Ok(ByteBoolArray::new(array.buffer().clone(), Validity::AllValid).into_array());
}
// all invalid => fill with default value (false)
if validity.all_false() {
return Ok(
ByteBoolArray::from_vec(vec![false; array.len()], Validity::AllValid).into_array(),
);
}
let validity = validity
.to_null_buffer()
.ok_or_else(|| vortex_err!("Failed to convert array validity to null buffer"))?;
let bools = array.as_slice();
let mut last_value = bool::default();
let filled = bools
.iter()
.zip(validity.inner().iter())
.map(|(&v, is_valid)| {
if is_valid {
last_value = v
}
last_value
})
.collect::<Vec<_>>();
Ok(ByteBoolArray::from_vec(filled, Validity::AllValid).into_array())
}
}
#[cfg(test)]
mod tests {
use vortex_array::compute::test_harness::test_mask;
use vortex_array::compute::{Operator, compare, scalar_at, slice};
use super::*;
#[test]
fn test_slice() {
let original = vec![Some(true), Some(true), None, Some(false), None];
let vortex_arr = ByteBoolArray::from(original);
let sliced_arr = slice(&vortex_arr, 1, 4).unwrap();
let sliced_arr = ByteBoolArray::try_from(sliced_arr).unwrap();
let s = scalar_at(&sliced_arr, 0).unwrap();
assert_eq!(s.as_bool().value(), Some(true));
let s = scalar_at(&sliced_arr, 1).unwrap();
assert!(!sliced_arr.is_valid(1).unwrap());
assert!(s.is_null());
assert_eq!(s.as_bool().value(), None);
let s = scalar_at(&sliced_arr, 2).unwrap();
assert_eq!(s.as_bool().value(), Some(false));
}
#[test]
fn test_compare_all_equal() {
let lhs = ByteBoolArray::from(vec![true; 5]);
let rhs = ByteBoolArray::from(vec![true; 5]);
let arr = compare(&lhs, &rhs, Operator::Eq).unwrap();
for i in 0..arr.len() {
let s = scalar_at(&arr, i).unwrap();
assert!(s.is_valid());
assert_eq!(s.as_bool().value(), Some(true));
}
}
#[test]
fn test_compare_all_different() {
let lhs = ByteBoolArray::from(vec![false; 5]);
let rhs = ByteBoolArray::from(vec![true; 5]);
let arr = compare(&lhs, &rhs, Operator::Eq).unwrap();
for i in 0..arr.len() {
let s = scalar_at(&arr, i).unwrap();
assert!(s.is_valid());
assert_eq!(s.as_bool().value(), Some(false));
}
}
#[test]
fn test_compare_with_nulls() {
let lhs = ByteBoolArray::from(vec![true; 5]);
let rhs = ByteBoolArray::from(vec![Some(true), Some(true), Some(true), Some(false), None]);
let arr = compare(&lhs, &rhs, Operator::Eq).unwrap();
for i in 0..3 {
let s = scalar_at(&arr, i).unwrap();
assert!(s.is_valid());
assert_eq!(s.as_bool().value(), Some(true));
}
let s = scalar_at(&arr, 3).unwrap();
assert!(s.is_valid());
assert_eq!(s.as_bool().value(), Some(false));
let s = scalar_at(&arr, 4).unwrap();
assert!(s.is_null());
}
#[test]
fn test_mask_byte_bool() {
test_mask(&ByteBoolArray::from(vec![true, false, true, true, false]));
test_mask(&ByteBoolArray::from(vec![
Some(true),
Some(true),
None,
Some(false),
None,
]));
}
}