Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Use entity rather than object and relationship #216

Closed
wants to merge 74 commits into from
Closed

WIP Use entity rather than object and relationship #216

wants to merge 74 commits into from

Conversation

manuelma
Copy link
Collaborator

@manuelma manuelma commented Feb 9, 2023

Fixes #215

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@manuelma manuelma changed the title WIP: Issue 215 drop object and relationship WIP: Use entity rather than object and relationship Feb 9, 2023
@manuelma manuelma changed the title WIP: Use entity rather than object and relationship WIP Use entity rather than object and relationship Feb 10, 2023
@jkiviluo
Copy link
Member

jkiviluo commented Mar 2, 2023

Importing entities with an importer overwrites entity_classes in the DB (including entity_class icons, which is why I noticed. The new entity_class icons are the default ones).

@jkiviluo
Copy link
Member

jkiviluo commented Mar 2, 2023

I have this:
image

And for some reason exporter wants to export the coal entity twice (but not the others):
image

manuelma added 14 commits March 13, 2023 16:51
@manuelma
Merge branch 'master' into issue_215_drop_object_and_relationship
0b18887
@manuelma
Fix some tests
504baf6
@manuelma
Fix lots of tests and missing bits
5070d7c
@manuelma
Merge branch 'master' into issue_215_drop_object_and_relationship
c80717f
@manuelma
Fix more tests
1bc8aff
@manuelma
Fix remove_items and descendant_tablenames to use entity
3e41455
@manuelma
Fix a couple more tests
c6c9b53
@manuelma
Fix details in import entities etc
e0532cc
@manuelma
Adapt ImportMapping to the entity structure
7131aea
@manuelma
Adapt part of the ExportMapping to entity design
daaee5c
@manuelma
Fix a couple more tests
676b88a
@manuelma
Some renaming and fix export entity classes
b54242f
@manuelma
Introduce id generator and order entities in import mapping so it works
8e73a80 
Since now we import objects and relationships together via the
"entities" key, we need to make sure the elements are in the right order
so 0-dimensional entities are processed before multidimensional ones
(because the latter may need the former). This implies even assigning
an id to the 0-dimensional ones *before* they are actually added to
the db, and this is done with a context manager.
@manuelma
Fix tests
703e8c1
manuelma and others added 28 commits May 16, 2023 16:52
@manuelma
Fix various bugs found via tests
00ed8b3
@manuelma
Get rid of DBMappingBase.connection and move asynch back to toolbox
7d4d0fe
@manuelma
Add commit_id to committed items
7525f0a
@soininen
Merge branch 'master' into issue_215_drop_object_and_relationship
bb3556d
@manuelma
Fix tests
3b0e110
@soininen
Merge branch 'issue_215_drop_object_and_relationship' of github.com:s…
757a4b1 
…pine-tools/Spine-Database-API into issue_215_drop_object_and_relationship
@soininen
Merge branch 'issue_215_drop_object_and_relationship' of github.com:s…
a0efed6 
…pine-tools/Spine-Database-API into issue_215_drop_object_and_relationship
@soininen
Black formatting
3172ee1 
Re #215
@manuelma
Implement rollback
8e95ce8
@manuelma
Import zero dim entities before the others, so it works
4c6a1ea
@manuelma
Consolidate DatabaseMapping tests
c29b4b6
@manuelma
Implement refresh_session, fix query and add rollback_session tests
68f3ffe
@manuelma
Fix minor things and add tests for refresh_session
4da0da2
@manuelma
Fix refresh and implement dirty_ids
1ff78a4
@manuelma
Fix management of unique keys
c483aca
@manuelma
Document CacheItemBase
69d15ce
@manuelma
Fix db server query entry point
2a2c7a6
@manuelma
Merge remote-tracking branch 'origin/master' into issue_215_drop_obje…
cbbb1d6 
…ct_and_relationship
@manuelma
Fix calling callbacks while others are added from another thread
ad5ec65
@manuelma
Fix some issues with temp id replacement
7400979
@manuelma
Return layout coordinates
176cac4
@manuelma
Fix CacheItem status change
13c8238
@manuelma
Fix issues with list_value_id
a33d529
@manuelma
Make cascade restore sensitive to the removal source
9fb98cf
@manuelma
Fix ParameterValue unique key
61de5ff
@manuelma
Merge branch 'master' into issue_215_drop_object_and_relationship
7a276ae
@manuelma
Simplify TempId resolving and parameter queries
36acf4f
@manuelma
Merge branch 'master' into issue_215_drop_object_and_relationship
60f7134
@manuelma manuelma closed this Aug 29, 2023
@manuelma manuelma deleted the issue_215_drop_object_and_relationship branch August 29, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop object and relationship and keep only entity
4 participants
@manuelma @jkiviluo @codecov-commenter @soininen