Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework spire-server validate command to launch plugin instances for validation. #5268

Open
edwbuck opened this issue Jul 1, 2024 · 1 comment · May be fixed by #5626
Open

Rework spire-server validate command to launch plugin instances for validation. #5268

edwbuck opened this issue Jul 1, 2024 · 1 comment · May be fixed by #5626
Labels
priority/backlog Issue is approved and in the backlog
Milestone

Comments

@edwbuck
Copy link
Contributor

edwbuck commented Jul 1, 2024

Currently the SPIRE server has a command to validate the configuration file. This request would extend the validation to have per-plugin validation be part of the process, using the newly added "Validate" RPC provided by the spire-plugin-sdk "config" service.

Upon running the command, the logic would launch (in a non-conflicting manner) an instance of each plugin referenced in the configuration and pass the configuration to the plugin's Validate func.

After the core configuration an all plugins report valid / invalid status, the results would be combined for feedback to the administrator that validated the configuration.

Validation is limited to ensuring that the correct fields are present, they have values of the correct types, and where they must agree with each other internally, they agree.

Validation doesn't extend to anything that requires the additional reads of config files not related to SPIRE, opening sockets, or communicating to other systems.

@evan2645 evan2645 added triage/in-progress Issue triage is in progress priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels Jul 2, 2024
@edwbuck
Copy link
Contributor Author

edwbuck commented Aug 23, 2024

Adding a note that the output of the CLI should likely contain two formats. One for easy human reading, and preferably a JSON output for automated parsing of the output.

@azdagron azdagron added this to the 1.11.1 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants