Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#39 is back in v0.6.0 #453

Open
szvincze opened this issue Dec 7, 2024 · 3 comments
Open

#39 is back in v0.6.0 #453

szvincze opened this issue Dec 7, 2024 · 3 comments

Comments

@szvincze
Copy link

szvincze commented Dec 7, 2024

It seems that the solution of #39 is missing from v0.6.0 therefore there is a restart because the spire-server socket is not ready.
@faisal-memon
Copy link
Contributor

It got removed with #418, bumping the controller-runtime version

@szvincze
Copy link
Author

It got removed with #418, bumping the controller-runtime version

Thanks, @faisal-memon.

I have seen it got removed, but this way it causes unwanted container restart again. Do you plan to include it again?

@faisal-memon
Copy link
Contributor

@szvincze Yes we should add this functionality back in. The API has changed and there is a few different ways to go about it. Will update with a few different options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faisal-memon @szvincze