Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin generates incorrect URL in JSON for Vimeo MP4 links #285

Open
rutgerbakker95 opened this issue Dec 18, 2024 · 0 comments
Open

Plugin generates incorrect URL in JSON for Vimeo MP4 links #285

rutgerbakker95 opened this issue Dec 18, 2024 · 0 comments
Labels

Comments

@rutgerbakker95
Copy link

Bug Description

When uploading a Vimeo MP4 video URL using the Embedded Assets plugin, the generated JSON contains an incorrect URL in the "url" field. The plugin is replacing the original Vimeo player URL with a temporary download URL from vimeocdn.com, which can expire and break the video embedding.

Steps to reproduce

  1. Install and configure the Embedded Assets plugin in Craft CMS
  2. Attempt to embed a Vimeo MP4 URL in the following format:
    https://player.vimeo.com/progressive_redirect/playback/[VIDEO_ID]/rendition/1080p/file.mp4?loc=external&log_user=0&signature=[signature]
    
  3. Check the generated JSON file for the embedded asset

Expected behaviour

The "url" field in the generated JSON should maintain the original Vimeo player URL that was input, matching the URL used in the "title" and "code" fields of the JSON.

JSON Comparison:

{
    ...
-   "url": "https://download-video-ak.vimeocdn.com/v3-1/playback/fe6276a6-0b86-4c70-9810-68bb2916cdc9/84742910-aae21fc1?__token__=st=1734341381~exp=1734355781~acl=%2Fv3-1%2Fplayback%2Ffe6276a6-0b86-4c70-9810-68bb2916cdc9%2F84742910-aae21fc1%2A~hmac=8471e1df95404c3264727ebb1c86649474e8ea62a7f4f98b873816c8d061e229&r=dXMtZWFzdDE%3D",
+   "url": "https://player.vimeo.com/progressive_redirect/playback/726936734/rendition/720p/file.mp4?loc=external&log_user=0&signature=b5d786b1c8c5c69d9f9ced37c4a8acfe2e1a8e09b32ee832cd93524ebe4a32fc",
    ...
}

Embedded Assets version

4.2.0 (also newer 5 versions)

Craft CMS version

4.13.1.1 (also newer 5 versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant