From e7557cd1b7facfe35cd7adda01ffe263831e6cc8 Mon Sep 17 00:00:00 2001
From: Alex Gabites <alex@netspeed.net.nz>
Date: Sun, 28 Feb 2021 17:09:00 +1300
Subject: [PATCH] update github ci workflows

---
 .github/workflows/pull_request.yaml | 6 +++---
 .github/workflows/push.yaml         | 7 ++++---
 .github/workflows/release.yaml      | 7 ++++---
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml
index bcb9154f..322c583e 100644
--- a/.github/workflows/pull_request.yaml
+++ b/.github/workflows/pull_request.yaml
@@ -7,7 +7,7 @@ on:
       - synchronize
 
 jobs:
-  deployDraftOnAnyPullRequest:
+  deploy-draft-on-any-pull-request:
     name: Deploy draft to Netlify
     runs-on: ubuntu-latest
     if: github.event_name == 'pull_request' && github.ref != 'refs/heads/master'
@@ -22,11 +22,11 @@ jobs:
         run: npm run build:storybook
 
       - name: Deploy draft to Netlify
-        uses: South-Paw/action-netlify-deploy@v1.0.4
+        uses: South-Paw/action-netlify-deploy@v1.2.0
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           netlify-auth-token: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           netlify-site-id: ${{ secrets.NETLIFY_SITE_ID }}
           build-dir: "./storybook-static"
+          github-deployment-environment: development
           draft: true
-          comment-on-pull-request: true
diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml
index 966a20f4..dac89fb0 100644
--- a/.github/workflows/push.yaml
+++ b/.github/workflows/push.yaml
@@ -29,9 +29,9 @@ jobs:
         run: npm ci
 
       - name: Test
+        run: npm run test
         env:
           CI: true
-        run: npm run test
 
   build:
     name: Build
@@ -47,7 +47,7 @@ jobs:
       - name: Build Package
         run: npm run build
 
-  deployDraftOnMasterCommit:
+  deploy-draft-on-master-commit:
     name: Deploy draft to Netlify
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && github.ref == 'refs/heads/master'
@@ -62,11 +62,12 @@ jobs:
         run: npm run build:storybook
 
       - name: Deploy draft build to Netlify
-        uses: South-Paw/action-netlify-deploy@v1.0.4
+        uses: South-Paw/action-netlify-deploy@v1.2.0
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           netlify-auth-token: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           netlify-site-id: ${{ secrets.NETLIFY_SITE_ID }}
           build-dir: "./storybook-static"
+          github-deployment-environment: development
           draft: true
           comment-on-commit: true
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 14869750..2f62071a 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -6,7 +6,7 @@ on:
       - created
 
 jobs:
-  deployProductionOnMasterRelease:
+  deploy-production-on-master-release:
     name: Publish release to Netlify
     runs-on: ubuntu-latest
     if: github.event_name == 'release' && github.event.action == 'created'
@@ -21,15 +21,16 @@ jobs:
         run: npm run build:storybook
 
       - name: Deploy production to Netlify
-        uses: South-Paw/action-netlify-deploy@v1.0.4
+        uses: South-Paw/action-netlify-deploy@v1.2.0
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           netlify-auth-token: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           netlify-site-id: ${{ secrets.NETLIFY_SITE_ID }}
           build-dir: "./storybook-static"
+          github-deployment-environment: production
           comment-on-commit: true
 
-  publishPackage:
+  publish-package:
     name: Publish
     runs-on: ubuntu-latest
     if: github.event_name == 'release' && github.event.action == 'created'