Added support for base64 encoded remote config, fixes #162 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption address was returned to base64
RongDuJiKsp
changed the title
|
Thank you for this contribution! I will need some time to review your changes. In the meantime, please adjust your PR according to the format/style checks in the CI. ❤️ |
spencerwooo
changed the title
remote_config_encoding, fixes #162
spencerwooo
changed the title
remote_config_encoding, fixes #162
spencerwooo
reviewed
Sep 18, 2024
spencerwooo
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Considering the base64 file decoding fails silently and keeps the original file intact, I would prefer removing the requirement for enabling the decoding via remote_config_encoding configuration option, and always apply the base64 decoding regardless of the file format.
Could you please remove any related logic and update this PR? Thanks. ❤️
spencerwooo
approved these changes
Sep 19, 2024
|
Thanks again for the effort 🤩 |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the configuration item remote_config_encoding. When the configuration item is "plain", it will not be processed. When the configuration item is "base64", it will attempt to base64 decoding of the subscription address.
Linked Issues
fixes #162
Additional context
This is my first PR.I tested my code ,but I don't know the workflow. If I am at fault, please correct me :)