Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring data loading functionality currently within Calc #285

Open
spencerahill opened this issue Jun 12, 2018 · 0 comments
Open

Refactoring data loading functionality currently within Calc #285

spencerahill opened this issue Jun 12, 2018 · 0 comments

Comments

@spencerahill
Copy link
Owner

C.f. discussion in #284, which I'll paste here:

Note that I do use Calc.load itself, still, so that should remain for now. Although I think it would still make sense to segregate it from Calc itself eventually...maybe a CalcDataLoader?

Yes I think there is a lot of room for improvement here. When plotting data produced by aospy it is often helpful to not just load individual calculations, but to load groups of them. For example something as simple as loading a particular calculation for a set of runs, and concatenating along a new dimension indexed by the run names can be very convenient. I've written various functions over the years to do variants of that where needed.

I have done the same. Most recently, I've generated a CalcSuite to dispatch the Calc objects I need for the data I want to load, and then loop through them calling their load method.

Within load, there are two pathways: from the primary output target containing netCDF files and from the secondary tar archive. So we need to account for both of them in any refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant