CommandAppTester overrides console

[byte2pixel]

I have been banging my head as to why my unit tests of a single command will pass with doing interactive things. I can create a TestConsole() and set .Interactive = true and provide inputs and it works.

But if I create an integration test using CommandAppTester no matter what I do I always get the console is not interactive.

What I found is that CommandAppTester ignores any console I try to provide.

Whether I try using dependency injection, or app.ConfigureConsole

I found the reason why.

CommandAppTester doesn't use any configured console or check for one in the DI container it just creates a new one.

    public async Task<CommandAppResult> RunAsync(params string[] args)
    {
       // This line here
        var console = new TestConsole().Width(int.MaxValue);
        return await RunAsync(args, console);
    }

What I think should happen is maybe

• use the DI container first(Registrar), if not found there
• then use the configurator.Settings.Console and if not there
• then create a new one?

Thoughts?

If approved, I would be willing to create an issue and open a PR.

[FrankRay78]

A fix has been approved @byte2pixel, see here: #1718

[byte2pixel]

Awesome thanks

[FrankRay78]

Well, lets see if a PR is forthcoming... I'll give it a week or two, then you'd be welcome.

[FrankRay78]

There are other open issues @byte2pixel if you want to contribute - if so, let me know and I can suggest some to look.

[byte2pixel]

Sure, something good for someone new to the project.

…

On Fri, Jan 31, 2025, 09:30 Frank Ray ***@***.***> wrote: There are other open issues @byte2pixel <https://github.com/byte2pixel> if you want to contribute - if so, let me know and I can suggest some to look. — Reply to this email directly, view it on GitHub <#1713 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHQZUTM2VHVBESJLB557B532NOJIDAVCNFSM6AAAAABTLO5J66VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMBRHEYTGOA> . You are receiving this because you were mentioned.Message ID: <spectreconsole/spectre.console/repo-discussions/1713/comments/12019138@ github.com>

[FrankRay78]

I maintain the CLI sub-system so if we stick to that, it means I will be able to review/merge any contributions without waiting on anyone else. There's also never any pressure to do anything, as it's voluntary after all. I'll take a look and aim to have a few suggestions mid-next week.

[byte2pixel]

That works for me. I've use Spectre Console for a few hobby projects, not for my work (but would if given the chance!), but I enjoy it and want to see what I can do to give back some.

[FrankRay78]

I've not forgotton @byte2pixel - just putting out a couple of burning fires. I hope to get to this soon.