Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

What to do about R6 Dimension Styles? #140

Open
fraguada opened this issue Mar 1, 2018 · 4 comments
Open

What to do about R6 Dimension Styles? #140

fraguada opened this issue Mar 1, 2018 · 4 comments
Assignees
Milestone

Comments

@fraguada
Copy link
Collaborator

fraguada commented Mar 1, 2018

What would be the strategy to add support for Rhino 6 Dimension styles without polluting SpeckleCore with app specific stuff? I guess SpeckleAnnotation can have user data, so that might be the place to start? Then during deserialization, if R6, check UD and if there is a DimStyle entry, suck it up. 🤔

@didimitrie
Copy link
Member

What about creating a new SpeckleObject in Core that handles dimensions, ie SpeckleDimension? Would have SpeckleAnnotation for:

  • text dots
  • text

SpeckleDimension:

  • linear dim
  • radial dims
  • etc.

Watcha think? It's wide used enough to enable this as a fundamental object?

@fraguada
Copy link
Collaborator Author

fraguada commented Mar 1, 2018

DimensionStyles in R6 apply to all AnnotationBase objects, including TextEntity, lineardims, etc.. let's say, these are attributes that go along with all annotations. I'm not sure this is a universal pattern.

@didimitrie
Copy link
Member

so then it doesn't make sense to split them up? my lizard brain says yes, but then we could resolve this by adding _type prop to spk annotations that tells us more explicitly what it is, and then we just leave everything else for the properties/UD

@fraguada fraguada added this to the 0.6.0 milestone Mar 1, 2018
@fraguada
Copy link
Collaborator Author

fraguada commented Mar 1, 2018

Moving this to 0.6.0 for now. There should be basic Text / TextDot support in 0.5.0. Relates to #113.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants