Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-solid extrusions fail #40

Open
1 task done
didimitrie opened this issue Jun 1, 2018 · 2 comments
Open
1 task done

Non-solid extrusions fail #40

didimitrie opened this issue Jun 1, 2018 · 2 comments
Labels
enhancement New feature or request viewer issues relating to the 3d viewer

Comments

@didimitrie
Copy link
Member

Step 0:

Expected Behaviour

Extrusions seem to be not really working with non-solid ones. A single/curve/polyline/polycurve line is extruded in an open surface, but threejs fills it up.

Affected Projects

Does this issue propagate to other dependencies or dependants? If so, list them here!

Reproduction Steps & System Config (win, osx, web, etc.)

StreamId: B1zNJbklm @ speckle hestia

image

@mswaidan
Copy link
Collaborator

Three.js extrusions are based on shapes. They're closed paths by definition (plus some holes), so I don't think an open threejs extrusion is possible. We'll need to treat open extrusions as breps in the converter.

@didimitrie
Copy link
Member Author

hm... then we need to handle this via checking if the extrusion is closed or not (is this even in SpeckleCore?). If closed, we're cool, if not closed (ie, just a line of sorts), we'll need to write some custom code to extrude it. I guess.

I wouldn't treat them as breps, as this makes these things heavier than they need to be, unless what you had in mind is just try to extract a displayMesh like we do for breps though? and then in a threejs client we request just the displayMesh, and in a Rhino client we get the extrusion proper?

@didimitrie didimitrie transferred this issue from speckleworks/SpeckleViewer May 1, 2019
@didimitrie didimitrie added enhancement New feature or request viewer issues relating to the 3d viewer labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request viewer issues relating to the 3d viewer
Projects
None yet
Development

No branches or pull requests

2 participants