Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery of branch selection doesn't work after a send operation #205

Closed
JR-Morgan opened this issue Jul 23, 2024 · 6 comments · Fixed by #207
Closed

Recovery of branch selection doesn't work after a send operation #205

JR-Morgan opened this issue Jul 23, 2024 · 6 comments · Fixed by #207
Labels
bug Something isn't working

Comments

@JR-Morgan
Copy link
Member

As part of the send operation, the last step refreshes the UI so that the commit just sent displays in the UI

The branch recovery feature introduced by #196 doesn't work for this case...

Steps to reproduce:

  1. Select a branch
  2. Select objects & send
  3. observe branch gets set to main after send
@JR-Morgan
Copy link
Member Author

Blender bug report

A more detailed steps to reproduce:

  • From the list of Speckle projects, select a project that isn't the first project
  • Send an object to a said project
  • Observe, that the selection is in an invalid state, where no models appear in the drop down, and trying to receive leads to an unhandled exception

@JR-Morgan
Copy link
Member Author

@overengineer are you interested in trying to find a fix,
again, no worries if you're busy, but please let me know.

@overengineer
Copy link
Contributor

Imma look into it

@overengineer
Copy link
Contributor

Selected commit should change to the new commit after send operation, right?

@JR-Morgan
Copy link
Member Author

ideally, yes

@overengineer
Copy link
Contributor

overengineer commented Aug 1, 2024

That was a strange bug. Active stream is reset on send operation. I overrode it on selection restoration.
Furthermore, there were two different cases. One is branch selection on default stream. Other is branch selection on a selected stream. This PR (#207) fixes both

@JR-Morgan JR-Morgan linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants