Adding paleo context as subview in collecting event table causes issues

[yvonneekanim]

I've attached screenshots of what the same paleo context subform looks like as a subview in CE table vs CO table. It looks the same in both tables in Specify 6
Paleo context subform in collecting event table:

Paleo context subform in collection object table:

[yvonneekanim]

Paleo context only works as a subview in CO if it is embedded

[grantfitzsimmons]

I have not been able to to add a paleoContext subview on the CE form. It appears but I cannot add items.

                <row>
                    <cell type="label" labelfor="pcsh"/>
                    <cell type="field" uitype="querycbx" id="pcsh" name="paleoContext" initialize="name=PaleoContext" colspan="10"/>
                </row>
                <row>
                    <cell type="subview" viewname="SubPaleoContext" id="pcem" name="paleoContext" defaulttype="table" colspan="9"/>
                </row>

db: Invertpaleo
https://testability.test.specifysystems.org/specify/view/collectingevent/new/

[maxpatiiuk]

It looks like SubViews for independent fields are rendered as read-only.
I copied that logic from the previous implementation of SubViews:

specify7/specifyweb/frontend/js_src/lib/subview.js

Line 49 in 7fd134e

var mode = self.field.isDependent() && !this.readOnly ? 'edit' : 'view';

It's easy to remove that.
@benanhalt do you know why that was added initially?

Is it related to #114?

[benanhalt]

Yes. That is the intended behavior. If the paleocontext is set to be embedded according to the schema, then self.field.isDependent() should be true. If it's not then that is the bug.

[maxpatiiuk]

That is the intended behavior

Can you explain why?

Also, CollectingEvent -> paleoContext is not set as dependent at the moment.

[grantfitzsimmons]

When creating a new accession record in Specify 6, the Repository Agreement subview under the Accession table is working correctly.

When creating a record in Specify 7, there is no way to add a Repository Agreement to an Accession record. The + icon is disabled.

This is in the same database with the same forms.

The behavior begins to complicate after saving the Accession record:

Now a Repository Agreement is randomly assigned. I created a single repository agreement in this database and it immediately selected it. There is no way to remove this relationship or modify it.

When viewing the same record in Specify 6, it shows there is no Repository Agreement assigned.

Database: pripaleo
User: kmiller

https://pripaleo-edge.test.specifysystems.org/specify/view/collectionobject/70641/

paleo.views.xml

Reported By: Matthew Cruz at The University of Michigan

[grantfitzsimmons]

@maxpatiiuk

It affects all subviews to non-dependent relationships. We need to figure out why that limitation was put in place. Once we do, removing it is easy.

[maxpatiiuk]

Solutions:

• Either mark paleo context relationship as dependent
• Or, render the relationship as a query combo box rather than a SubView. @grantfitzsimmons does this solution work for you?

[grantfitzsimmons]

What is the issue with marking paleo context as dependent?

[grantfitzsimmons]

And how can I verify that this has been solved? Is it on testability?

[maxpatiiuk]

This has not been fixed yet. If you want paleo context to be displayed as a SubView, ask Ben to mark it as a dependent

[grantfitzsimmons]

@benanhalt Can you mark this relationship as dependent to solve this problem?

[benanhalt]

It isn't always dependent. It can be set to embedded or not, and also it can be set to be embedded in different tables. So the dependent status depends on those settings. I can check to see if it is properly respecting the settings.

[benanhalt]

The logic is handled here:

specify7/specifyweb/frontend/js_src/lib/specifyfield.ts

Lines 282 to 291 in d9776d6

	public isDependent(): boolean {
	// TODO: move this into SchemaExtras.ts
	return this.model.name == 'CollectionObject' &&
	this.name == 'collectingEvent'
	? schema.embeddedCollectingEvent
	: this.model.name.toLowerCase() == schema.paleoContextChildTable &&
	this.name == 'paleoContext'
	? schema.embeddedPaleoContext
	: this.dependent;
	}

It looks like it is implemented so you need to check if the database has paleo context set to be embedded in collecting event in this database.

[maxpatiiuk]

Now a Repository Agreement is randomly assigned. I created a single repository agreement in this database and it immediately selected it. There is no way to remove this relationship or modify it.

This could be just a visual bug. @grantfitzsimmons Are you still able to replicate it

Current behavior:
If "embeddedPaleoContext" boolean is true for the current collection (can be changed on the collection form), then Paleo Context can be displayed as a SubView/form table. Otherwise, it can only be displayed as a query combo box or a subview button
@grantfitzsimmons does that sound good? In which case this issue can be closed

[grantfitzsimmons]

Same rule applies to Collecting Events.

If "IsEmbeddedCollectingEvent" boolean is true for the current collection (can be changed on the collection form), then Collecting Event can be displayed as a SubView/form table. Otherwise, it can only be displayed as a query combo box or a subview button