Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sorting items in the create loan dialog #5142

Open
grantfitzsimmons opened this issue Jul 25, 2024 · 1 comment · May be fixed by #5214
Open

Allow sorting items in the create loan dialog #5142

grantfitzsimmons opened this issue Jul 25, 2024 · 1 comment · May be fixed by #5214
Labels
1 - Request Improvements or extensions to existing behavior 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more good first issue

Comments

@grantfitzsimmons
Copy link
Member

image

It would be useful to sort by Prep Type so the correct items can be chosen

Requested by: RBGE
@grantfitzsimmons grantfitzsimmons added 1 - Request Improvements or extensions to existing behavior 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more good first issue labels Jul 25, 2024
@maxpatiiuk
Copy link
Member

It isn't implemented in this dialog because those counts are fetched async.
This means that we either need to show a screen-wide loading bar until all counts are loaded, or to are going to see rows jumping around until all are loaded

as a compromise, we could make the headers clickable for sorting once all rows are loaded, but not store the sort preference in local storage so that it is back to unsorted next time it's opened

@grantfitzsimmons grantfitzsimmons linked a pull request Aug 12, 2024 that will close this issue
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - Request Improvements or extensions to existing behavior 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for sorting columns in prep dialog specify/specify7
2 participants
@grantfitzsimmons @maxpatiiuk