idlocker

[lijhnihaoa]

No description provided.

[lijhnihaoa]

Why use this lock again now? Didn't you say it was unnecessary?

[cyb70289]

???

[cyb70289]

What are you saying?

[lijhnihaoa]

https://review.spdk.io/gerrit/c/spdk/spdk-csi/+/14907/comment/6c69e4af_093bbfb9/

[lijhnihaoa]

Now the locks are changed to this, I think the change is quite big

[cyb70289]

Code review is a two way communication process. You can propose your own ideas.
It's very common that some ideas are changed during the review process.
Instead of complaining, I think a better attitude is to help reviewing patches from others.
Maintainers are just normal humans. They often review code by sacrificing their own spare time.

[cyb70289]

Also, this is SPDK community github repo, not my personal one.
Issues like this doesn't make sense.
You can message me directly.

[lijhnihaoa]

Sorry，I think you misunderstood me, I'm just asking the reason or benefit of using this now. After all, every change you make is well thought out.

[lijhnihaoa]

The modified program has some of the same ideas as the version I was based on.
for example:
urlSecrets map[string]util.RemoteStorageNode //rpcUrl to secret
csiVolume: csi.Volume{ VolumeId: remoteStorageNode.Info()[7:] + "-" + lvolID }

[cyb70289]

Anyway, contribution is always welcomed.

Will you close this issue?