From 63b5594d01c2f42c5ad6bf3e5eb52b594f8df328 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:54:48 +0100 Subject: [PATCH 01/11] common: add a step to create output_dir This will avoid repeating this operation multiple times. Technically auto[run|build|test].sh create a dir for output in 'spdk/../', but making it explicit makes it more clear. Additionally the output_dir is set by default one directory up from spdk. Use that to shorten the already unwieldy one-liner. Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 2 +- cijoe/workflows/autorun_in_qemu.yaml | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index 3a78f30..452c726 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -68,7 +68,7 @@ jobs: - name: qemu-guest, provision run: | cd ci/cijoe - cijoe guest_initialize guest_start guest_check tgz_transfer ci_configs_transfer tgz_unpack \ + cijoe guest_initialize guest_start guest_check tgz_transfer ci_configs_transfer tgz_unpack output_create \ --monitor \ --config configs/qemuhost-with-guest-fedora-40.toml \ --workflow workflows/autorun_in_qemu.yaml \ diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index b8ec337..5d84579 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -44,15 +44,17 @@ steps: tar xzf /tmp/repository.tar.gz -C /opt/spdk git config --global --add safe.directory /opt/spdk -- name: autorun_unittest +- name: output_create run: | mkdir -p /opt/output - output_dir=/opt/output /opt/spdk/autorun.sh /opt/configs/unittest.conf + +- name: autorun_unittest + run: | + /opt/spdk/autorun.sh /opt/configs/unittest.conf - name: autorun_nvme run: | - mkdir -p /opt/output - output_dir=/opt/output /opt/spdk/autorun.sh /opt/configs/nvme.conf + /opt/spdk/autorun.sh /opt/configs/nvme.conf - name: output_listing run: | From 875013d41952437564bad2f199ce83df822fcb02 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 6 Mar 2025 10:55:31 +0100 Subject: [PATCH 02/11] common: add safe.directory for submodules Some of the tests perform git operations on the submodules. Signed-off-by: Tomasz Zawadzki --- cijoe/workflows/autorun_in_qemu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 5d84579..db7fd8b 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -42,7 +42,7 @@ steps: run: | mkdir -p /opt/spdk tar xzf /tmp/repository.tar.gz -C /opt/spdk - git config --global --add safe.directory /opt/spdk + git config --global --add safe.directory '*' - name: output_create run: | From 6ba94080249bb550ee9a5b5059f2819c1ed2f589 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:10:02 +0100 Subject: [PATCH 03/11] common: add unit test jobs under gcc This is intended to match unittest-main-docker-autotest. Originaly this job was intended to run inside a container to make better use of resources than VMs. For jobs that do not run functional tests with SPDK. Meanwhile container images are not ready for spdk-ci, this is still executed in VM. Job was renamed to better match the intent: - 'main' to 'gcc', other jobs will be similar and have 'clang' and 'vagrant' - 'docker' to 'container' As for the steps, they do not use autorun.sh in order to skip parts that are required for functional tests - ex. setup.sh. On old CI setup it was demonstrably faster in execution, than just full autorun.sh. Yet it might not hold up today. To keep changes on SPDK repo to minimum, container jobs will still call functions from tests scripts directly. At some point it will need to re-evaluted if this is best approach. One note here is that $rootdir is usually set by autorun.sh script. Since we are not calling it, we need to set it manually. OCF is turned on, to match prior CI setup. Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 2 +- ...unittest.conf => unittest-gcc-container-autotest.conf} | 2 +- cijoe/workflows/autorun_in_qemu.yaml | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) rename cijoe/configs/autorun_configs/{unittest.conf => unittest-gcc-container-autotest.conf} (95%) diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index 452c726..e5e33d9 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -33,8 +33,8 @@ jobs: strategy: matrix: workflow: - - autorun_unittest - autorun_nvme + - unittest-gcc-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/configs/autorun_configs/unittest.conf b/cijoe/configs/autorun_configs/unittest-gcc-container-autotest.conf similarity index 95% rename from cijoe/configs/autorun_configs/unittest.conf rename to cijoe/configs/autorun_configs/unittest-gcc-container-autotest.conf index edd1d41..d83e756 100644 --- a/cijoe/configs/autorun_configs/unittest.conf +++ b/cijoe/configs/autorun_configs/unittest-gcc-container-autotest.conf @@ -6,7 +6,7 @@ SPDK_TEST_REDUCE=1 SPDK_TEST_VBDEV_COMPRESS=1 SPDK_TEST_CRYPTO=1 SPDK_TEST_FTL=1 -SPDK_TEST_OCF=0 +SPDK_TEST_OCF=1 SPDK_TEST_RAID=1 SPDK_TEST_RBD=1 SPDK_TEST_URING=1 diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index db7fd8b..357853e 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -48,14 +48,14 @@ steps: run: | mkdir -p /opt/output -- name: autorun_unittest - run: | - /opt/spdk/autorun.sh /opt/configs/unittest.conf - - name: autorun_nvme run: | /opt/spdk/autorun.sh /opt/configs/nvme.conf +- name: unittest-gcc-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/unittest-gcc-container-autotest.conf && ocf_precompile && unittest_build && ./test/unit/unittest.sh + - name: output_listing run: | ls /opt From fff96c0453c3894e9ce4570b5defd450933e4bff Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:54:30 +0100 Subject: [PATCH 04/11] common: add check_format job Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 1 + .../autorun_configs/check-format-container-autotest.conf | 1 + cijoe/workflows/autorun_in_qemu.yaml | 4 ++++ 3 files changed, 6 insertions(+) create mode 100644 cijoe/configs/autorun_configs/check-format-container-autotest.conf diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index e5e33d9..cf081c3 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -35,6 +35,7 @@ jobs: workflow: - autorun_nvme - unittest-gcc-container-autotest + - check-format-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/configs/autorun_configs/check-format-container-autotest.conf b/cijoe/configs/autorun_configs/check-format-container-autotest.conf new file mode 100644 index 0000000..884c939 --- /dev/null +++ b/cijoe/configs/autorun_configs/check-format-container-autotest.conf @@ -0,0 +1 @@ +CHECK_FORMAT_ONLY_DIFF=yes diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 357853e..951cb61 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -56,6 +56,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/unittest-gcc-container-autotest.conf && ocf_precompile && unittest_build && ./test/unit/unittest.sh +- name: check-format-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/check-format-container-autotest.conf && check_format + - name: output_listing run: | ls /opt From 4b13896b421808e767578220556e067032d16829 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 02:59:06 +0100 Subject: [PATCH 05/11] common: add gcc release build job s/main/gcc s/docker/container Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 1 + .../release-build-gcc-container-autotest.conf | 17 +++++++++++++++++ cijoe/workflows/autorun_in_qemu.yaml | 4 ++++ 3 files changed, 22 insertions(+) create mode 100644 cijoe/configs/autorun_configs/release-build-gcc-container-autotest.conf diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index cf081c3..bdace5b 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -36,6 +36,7 @@ jobs: - autorun_nvme - unittest-gcc-container-autotest - check-format-container-autotest + - release-build-gcc-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/configs/autorun_configs/release-build-gcc-container-autotest.conf b/cijoe/configs/autorun_configs/release-build-gcc-container-autotest.conf new file mode 100644 index 0000000..82e7ac6 --- /dev/null +++ b/cijoe/configs/autorun_configs/release-build-gcc-container-autotest.conf @@ -0,0 +1,17 @@ +SPDK_TEST_UNITTEST=1 +SPDK_TEST_BLOCKDEV=1 +SPDK_TEST_PMDK=1 +SPDK_TEST_ISAL=1 +SPDK_TEST_REDUCE=1 +SPDK_TEST_VBDEV_COMPRESS=1 +SPDK_TEST_CRYPTO=1 +SPDK_TEST_FTL=1 +SPDK_TEST_OCF=1 +SPDK_TEST_RAID=1 +SPDK_TEST_RBD=1 +SPDK_TEST_URING=1 +SPDK_TEST_NVME_CUSE=1 +SPDK_TEST_BLOBFS=1 +SPDK_TEST_VFIOUSER=1 +SPDK_TEST_XNVME=1 +SPDK_TEST_RELEASE_BUILD=1 diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 951cb61..4860e3d 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -60,6 +60,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/check-format-container-autotest.conf && check_format +- name: release-build-gcc-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/release-build-gcc-container-autotest.conf && build_release + - name: output_listing run: | ls /opt From 2b9d2c6e6bb9cd8fb7867e73b553d7cde7f9f8e3 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:05:44 +0100 Subject: [PATCH 06/11] common: add doc building job Note that empty.conf was added to avoid creating empty config files for jobs that require no such file. We might want to revist this requirement on some of the scripts in SPDK. s/docker/container Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 1 + cijoe/configs/autorun_configs/empty.conf | 0 cijoe/workflows/autorun_in_qemu.yaml | 4 ++++ 3 files changed, 5 insertions(+) create mode 100644 cijoe/configs/autorun_configs/empty.conf diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index bdace5b..b1de449 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -37,6 +37,7 @@ jobs: - unittest-gcc-container-autotest - check-format-container-autotest - release-build-gcc-container-autotest + - doc-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/configs/autorun_configs/empty.conf b/cijoe/configs/autorun_configs/empty.conf new file mode 100644 index 0000000..e69de29 diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 4860e3d..3e7b259 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -64,6 +64,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/release-build-gcc-container-autotest.conf && build_release +- name: doc-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/empty.conf && build_doc + - name: output_listing run: | ls /opt From b6f2cb98716ad524332f6e0a752c7e8da55a7850 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:08:06 +0100 Subject: [PATCH 07/11] common: add build-files job Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 1 + cijoe/workflows/autorun_in_qemu.yaml | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index b1de449..bd5a342 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -38,6 +38,7 @@ jobs: - check-format-container-autotest - release-build-gcc-container-autotest - doc-container-autotest + - build-files-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 3e7b259..b7ab9e9 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -68,6 +68,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/empty.conf && build_doc +- name: build-files-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/empty.conf && build_files && dpdk_pci_api + - name: output_listing run: | ls /opt From f22a0f9d57a875fa8f106dd36f8b7cc0e011751f Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 03:01:47 +0100 Subject: [PATCH 08/11] common: add scan-build job Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 1 + .../scan-build-container-autotest.conf | 18 ++++++++++++++++++ cijoe/workflows/autorun_in_qemu.yaml | 4 ++++ 3 files changed, 23 insertions(+) create mode 100644 cijoe/configs/autorun_configs/scan-build-container-autotest.conf diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index bd5a342..11eabed 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -39,6 +39,7 @@ jobs: - release-build-gcc-container-autotest - doc-container-autotest - build-files-container-autotest + - scan-build-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm diff --git a/cijoe/configs/autorun_configs/scan-build-container-autotest.conf b/cijoe/configs/autorun_configs/scan-build-container-autotest.conf new file mode 100644 index 0000000..847f9e9 --- /dev/null +++ b/cijoe/configs/autorun_configs/scan-build-container-autotest.conf @@ -0,0 +1,18 @@ +SPDK_TEST_SCANBUILD=1 +SPDK_TEST_BLOCKDEV=1 +SPDK_TEST_ISAL=1 +SPDK_TEST_REDUCE=1 +SPDK_TEST_VBDEV_COMPRESS=1 +SPDK_TEST_CRYPTO=1 +SPDK_TEST_FTL=1 +SPDK_TEST_OCF=1 +SPDK_TEST_RAID=1 +SPDK_TEST_RBD=1 +SPDK_TEST_URING=1 +SPDK_TEST_NVME_CUSE=1 +SPDK_TEST_BLOBFS=1 +SPDK_TEST_VFIOUSER=1 +SPDK_TEST_DAOS=0 +SPDK_RUN_ASAN=1 +SPDK_RUN_UBSAN=1 +SPDK_TEST_XNVME=1 diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index b7ab9e9..0854281 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -72,6 +72,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/empty.conf && build_files && dpdk_pci_api +- name: scan-build-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/scan-build-container-autotest.conf && ocf_precompile && scanbuild_make + - name: output_listing run: | ls /opt From 761cf1ca7fcefd6efa3bef8d5d2ba668267dd7c4 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Wed, 5 Mar 2025 04:45:55 +0100 Subject: [PATCH 09/11] common: add check_so_deps job Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 10 +++++++++- .github/workflows/spdk-common-tests.yml | 15 +++++++++++++++ .../check-so-deps-container-autotest.conf | 19 +++++++++++++++++++ cijoe/workflows/autorun_in_qemu.yaml | 12 ++++++++++++ 4 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 cijoe/configs/autorun_configs/check-so-deps-container-autotest.conf diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index 11eabed..d353de0 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -29,6 +29,7 @@ jobs: timeout-minutes: 35 env: REPOSITORY_TARBALL_PATH: ${{ github.workspace }}/repository.tar.gz + ABI_TARBALL_PATH: ${{ github.workspace }}/abi.tar.gz CI_CFGS_REPOSITORY_PATH: ${{ github.workspace }}/ci/cijoe/configs/autorun_configs strategy: matrix: @@ -40,6 +41,7 @@ jobs: - doc-container-autotest - build-files-container-autotest - scan-build-container-autotest + - check-so-deps-container-autotest container: image: ghcr.io/refenv/cijoe-docker:v0.9.50 options: --device=/dev/kvm @@ -59,9 +61,15 @@ jobs: with: name: repository + - name: Download the SPDK ABI repository + uses: actions/download-artifact@v4.1.8 + with: + name: abi + - name: Extract the SPDK repository run: | tar xzf repository.tar.gz --strip 1 + tar xzf abi.tar.gz --strip 1 - name: Download VM Qcow2 image artifact uses: actions/download-artifact@v4.1.8 @@ -73,7 +81,7 @@ jobs: - name: qemu-guest, provision run: | cd ci/cijoe - cijoe guest_initialize guest_start guest_check tgz_transfer ci_configs_transfer tgz_unpack output_create \ + cijoe guest_initialize guest_start guest_check tgz_transfer abi_transfer ci_configs_transfer tgz_unpack output_create \ --monitor \ --config configs/qemuhost-with-guest-fedora-40.toml \ --workflow workflows/autorun_in_qemu.yaml \ diff --git a/.github/workflows/spdk-common-tests.yml b/.github/workflows/spdk-common-tests.yml index 1490b1a..d35dc66 100644 --- a/.github/workflows/spdk-common-tests.yml +++ b/.github/workflows/spdk-common-tests.yml @@ -43,6 +43,21 @@ jobs: with: name: repository path: repository.tar.gz + + - name: Checkout the spdk-abi repo + uses: actions/checkout@v4.1.7 + with: + repository: 'spdk/spdk-abi' + path: './spdk-abi' + fetch-depth: '0' + fetch-tags: 'true' + - name: Create abi tarball + run: tar -C './spdk-abi' -czf abi.tar.gz . + - name: Upload the abi tarball as an artifact + uses: actions/upload-artifact@v4.4.0 + with: + name: abi + path: abi.tar.gz outputs: is_called: ${{ env.is_called }} diff --git a/cijoe/configs/autorun_configs/check-so-deps-container-autotest.conf b/cijoe/configs/autorun_configs/check-so-deps-container-autotest.conf new file mode 100644 index 0000000..35fa13e --- /dev/null +++ b/cijoe/configs/autorun_configs/check-so-deps-container-autotest.conf @@ -0,0 +1,19 @@ +SPDK_RUN_VALGRIND=0 +SPDK_TEST_UNITTEST=0 +SPDK_TEST_BLOCKDEV=1 +SPDK_TEST_ISAL=1 +SPDK_TEST_REDUCE=1 +SPDK_TEST_VBDEV_COMPRESS=1 +SPDK_TEST_CRYPTO=1 +SPDK_TEST_FTL=1 +SPDK_TEST_OCF=1 +SPDK_TEST_RAID=1 +SPDK_TEST_RBD=1 +SPDK_TEST_URING=1 +SPDK_TEST_NVME_CUSE=1 +SPDK_TEST_BLOBFS=1 +SPDK_TEST_VFIOUSER=1 +SPDK_TEST_DAOS=0 +SPDK_RUN_ASAN=1 +SPDK_RUN_UBSAN=1 +SPDK_TEST_XNVME=1 diff --git a/cijoe/workflows/autorun_in_qemu.yaml b/cijoe/workflows/autorun_in_qemu.yaml index 0854281..08950f1 100644 --- a/cijoe/workflows/autorun_in_qemu.yaml +++ b/cijoe/workflows/autorun_in_qemu.yaml @@ -32,6 +32,12 @@ steps: src: "{{ local.env.REPOSITORY_TARBALL_PATH }}" dst: /tmp/repository.tar.gz +- name: abi_transfer + uses: core.put + with: + src: "{{ local.env.ABI_TARBALL_PATH }}" + dst: /tmp/abi.tar.gz + - name: ci_configs_transfer uses: core.put with: @@ -42,6 +48,8 @@ steps: run: | mkdir -p /opt/spdk tar xzf /tmp/repository.tar.gz -C /opt/spdk + mkdir -p /opt/spdk-abi + tar xzf /tmp/abi.tar.gz -C /opt/spdk-abi git config --global --add safe.directory '*' - name: output_create @@ -76,6 +84,10 @@ steps: run: | rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/scan-build-container-autotest.conf && ocf_precompile && scanbuild_make +- name: check-so-deps-container-autotest + run: | + rootdir=/opt/spdk && cd $rootdir && source ./test/common/autobuild_common.sh /opt/configs/check-so-deps-container-autotest.conf && ocf_precompile && SPDK_ABI_DIR=/opt/spdk-abi check_so_deps + - name: output_listing run: | ls /opt From daffdf5f27b7ac0df881e5cdd7423a378e7d6aee Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 6 Mar 2025 13:57:59 +0100 Subject: [PATCH 10/11] common: extend job timeout to 60 minutes Tests like release build or scan-build jobs take around ~30min already, with longest running one I've seen at 32min. Let's extend it for now, and once we manage to get all required jobs in - figure out how to reduce the execution time. Signed-off-by: Tomasz Zawadzki --- .github/workflows/per_patch.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/per_patch.yml b/.github/workflows/per_patch.yml index d353de0..a98241f 100644 --- a/.github/workflows/per_patch.yml +++ b/.github/workflows/per_patch.yml @@ -26,7 +26,7 @@ jobs: autorun: needs: get_qcow runs-on: ubuntu-latest - timeout-minutes: 35 + timeout-minutes: 60 env: REPOSITORY_TARBALL_PATH: ${{ github.workspace }}/repository.tar.gz ABI_TARBALL_PATH: ${{ github.workspace }}/abi.tar.gz From e65f851fa1cab81c9a73ba6174554b35bf59d3bc Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 6 Mar 2025 14:09:31 +0100 Subject: [PATCH 11/11] common: adjust pattern for collecting output from jobs Probably '*-autotest_artifacts' would be better in the future, but still need to change the nvme job to match. Signed-off-by: Tomasz Zawadzki --- .github/workflows/spdk-common-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spdk-common-tests.yml b/.github/workflows/spdk-common-tests.yml index d35dc66..648668a 100644 --- a/.github/workflows/spdk-common-tests.yml +++ b/.github/workflows/spdk-common-tests.yml @@ -82,7 +82,7 @@ jobs: - name: Download artifact tarballs uses: actions/download-artifact@v4.1.8 with: - pattern: 'autorun_*_artifacts' + pattern: '*_artifacts' - name: Show artifacts run: |