Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Psalm on PHP 8.4 #439

Closed
Tracked by #438
spaze opened this issue Nov 23, 2024 · 2 comments · Fixed by #477
Closed
Tracked by #438

Test Psalm on PHP 8.4 #439

spaze opened this issue Nov 23, 2024 · 2 comments · Fixed by #477
Assignees

Comments

@spaze
Copy link
Owner

spaze commented Nov 23, 2024

  1. Add 8.4 here:

    php-version:
    - "8.3"

  2. Revert 36ed2ef of Run Psalm on PHP 8.3 #463

When the following is closed

@spaze spaze self-assigned this Nov 23, 2024
This was referenced Nov 23, 2024
@spaze
Copy link
Owner Author

spaze commented Jan 10, 2025

Wondering whether it's worth waiting for Psalm to support PHP 8.4. reading this comment teapot-php/status-code#167 (comment) prompted me to check the project activity:

Commits over time

There's been no commit for the past month (although I'm aware of Christmas etc.), last commit Dec 11, 2024, and there's been not a lot of commits before that either. There are PRs that fix some of the PHP 8.4 issues waiting to be merged since November 24.

So maybe don't delay the PHP 8.4 update by waiting for Psalm?

spaze added a commit that referenced this issue Jan 11, 2025
Psalm is not ready for PHP 8.4 yet, see #439
spaze added a commit that referenced this issue Jan 11, 2025
Tests using 8.3 removed except Psalm which is not ready for PHP 8.4 yet, see #439
spaze added a commit that referenced this issue Jan 11, 2025
This requires me to keep the following packages in my dev, some are for
Psalm itself, others allow it to analyze the code base:

php8.3-cli
php8.3-common
php8.3-intl
php8.3-mbstring
php8.3-opcache
php8.3-readline
php8.3-xml

They can be removed once Psalm supports PHP 8.4 (#439), or when I stop
using it.
@spaze spaze mentioned this issue Jan 27, 2025
@spaze spaze closed this as completed in b5c37c7 Jan 27, 2025
spaze added a commit that referenced this issue Jan 27, 2025
 - paragonie/halite updated from v5.1.2 to v5.1.3 patch
   See changes: paragonie/[email protected]
   Release notes: https://github.com/paragonie/halite/releases/tag/v5.1.3

 - psalm/phar updated from 5.26.1 to 6.0.0 major
   See changes: psalm/phar@5.26.1...6.0.0
   Release notes: https://github.com/psalm/phar/releases/tag/6.0.0

 - roave/security-advisories updated from dev-latest@fb6b004 to dev-latest@43863a2
   See changes: Roave/SecurityAdvisories@fb6b004...43863a2

 - spaze/phpcs-phar updated from 3.11.2 to 3.11.3 patch
   See changes: spaze/[email protected]
   Release notes: https://github.com/spaze/phpcs-phar/releases/tag/3.11.3

 - spaze/phpstan-disallowed-calls updated from v4.2.0 to v4.2.1 patch
   See changes: spaze/[email protected]
   Release notes: https://github.com/spaze/phpstan-disallowed-calls/releases/tag/v4.2.1

Run Psalm 6 on PHP 8.4 

Partially reverts #463
Close #439
Close #462
@spaze
Copy link
Owner Author

spaze commented Jan 27, 2025

Psalm updated to 6.0 and OS packages mentioned in #463 now uninstalled from my dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant