Creation of dynamic property $graceTimeInMinutes is deprecated

[raray]

I'm getting thousands of these messages since upgrading to PHP8.2:

Creation of dynamic property Illuminate\Console\Scheduling\Event::$graceTimeInMinutes is deprecated in ...

I'm sorry that I don't really have much to offer other than our usage which is:

protected function schedule(Schedule $schedule)
    {
        $schedule->command('sendEmails')->everyMinute()->graceTimeInMinutes(10);
        $schedule->command('sendPartnerEmails')->everyMinute()->graceTimeInMinutes(45);
    }

[wivaku]

Same for e.g.

Creation of dynamic property Illuminate\Console\Scheduling\Event::$monitorName is deprecated in .../vendor/spatie/laravel-schedule-monitor/src/ScheduleMonitorServiceProvider.php on line 105

[freekmurze]

I'd accept a PR that fixes this.

[akiyamaSM]

You need to upgrade the Laravel version to support 8.2. on my side the package worked for me under PHP 8.2.

[codetroll]

I upgraded to 8.2 - that didn't help. Besides - the requirement for laravel 10 states PHP 8.1/8.2 so some kind of workaround should probably be made for 8.1

[heikokrebs]

I still get this errors, despite the fix in #98 after upgrading to php 8.2
The properties are now declared at the ScheduleMonitorServiceProvider class but not on the Event and Callback classes - and cant be 🤔

Creation of dynamic property Illuminate\Console\Scheduling\Event::$monitorName is deprecated in …vendor/spatie/laravel-schedule-monitor/src/ScheduleMonitorServiceProvider.php on line 113

Creation of dynamic property Illuminate\Console\Scheduling\CallbackEvent::$monitorName is deprecated in …vendor/spatie/laravel-schedule-monitor/src/ScheduleMonitorServiceProvider.php on line 113

As stated here https://www.php.net/manual/en/migration82.deprecated.php:

The creation of dynamic properties is deprecated, unless the class opts in by using the #[\AllowDynamicProperties] attribute.

Both Illuminate\Console\Scheduling\Event and Illuminate\Console\Scheduling\CallbackEvent do not support this right now.
So this cant be fixed within the scope of this package? 🤔

[exophunk]

For me the same deprecation errors also still show up. The issue seems not to be fixed and maybe needs to be reopened? Maybe there is another mechanism how to add grace time or monitor name?

[heikokrebs]

@freekmurze do you have the opportunity to take another look here?

[freekmurze]

Currently short on time, if it's urgent, please submit a PR 👍

[heikokrebs]

@freekmurze unfortunately, i have no idea what a fix could look like. But I would like to use Oh Dear in this way with our account. Any idea/direction?