From d18288591013b68da4c0d106cc52c8d6977d269d Mon Sep 17 00:00:00 2001
From: Ruben Van Assche <rubenvanassche@gmail.com>
Date: Fri, 17 Jan 2025 10:53:56 +0100
Subject: [PATCH] Cleanup

---
 ...ionTraceArgumentsJsonSerializationTest.php | 41 -------------------
 tests/Fakes/NotExtendedDataClass.php          | 11 -----
 tests/SerializeableTest.php                   | 19 +++++++++
 3 files changed, 19 insertions(+), 52 deletions(-)
 delete mode 100644 tests/ExceptionTraceArgumentsJsonSerializationTest.php
 delete mode 100644 tests/Fakes/NotExtendedDataClass.php

diff --git a/tests/ExceptionTraceArgumentsJsonSerializationTest.php b/tests/ExceptionTraceArgumentsJsonSerializationTest.php
deleted file mode 100644
index 4e4093a0d..000000000
--- a/tests/ExceptionTraceArgumentsJsonSerializationTest.php
+++ /dev/null
@@ -1,41 +0,0 @@
-<?php
-
-use Spatie\LaravelData\Data;
-use Spatie\LaravelData\Exceptions\CannotCreateData;
-use Spatie\LaravelData\Tests\Fakes\NotExtendedDataClass;
-use Spatie\LaravelData\Tests\Fakes\SimpleData;
-
-// enable args in exception trace
-beforeEach(function () {
-    ini_set('zend.exception_ignore_args', 'Off');
-});
-
-it('can json_encode exception trace with args when not all required properties passed', function () {
-    try {
-        SimpleData::from([]);
-    } catch (CannotCreateData $e) {
-        $trace = $e->getTrace();
-        $encodedJson = json_encode($trace, JSON_THROW_ON_ERROR);
-
-        expect($encodedJson)->toBeJson();
-    }
-});
-
-it('can json_encode exception trace with args when nested property not extends Data or Dto class', function () {
-    $dataClass = new class ('', new NotExtendedDataClass('')) extends Data {
-        public function __construct(
-            public string $string,
-            public NotExtendedDataClass $nested
-        ) {
-        }
-    };
-
-    try {
-        $dataClass::from(['string' => '', 'nested' => ['name' => '']]);
-    } catch (TypeError $e) {
-        $trace = $e->getTrace();
-        $encodedJson = json_encode($trace, JSON_THROW_ON_ERROR);
-
-        expect($encodedJson)->toBeJson();
-    }
-});
diff --git a/tests/Fakes/NotExtendedDataClass.php b/tests/Fakes/NotExtendedDataClass.php
deleted file mode 100644
index 9c9dbecb9..000000000
--- a/tests/Fakes/NotExtendedDataClass.php
+++ /dev/null
@@ -1,11 +0,0 @@
-<?php
-
-namespace Spatie\LaravelData\Tests\Fakes;
-
-class NotExtendedDataClass
-{
-    public function __construct(
-        public string $name
-    ) {
-    }
-}
diff --git a/tests/SerializeableTest.php b/tests/SerializeableTest.php
index 7d9bc8b39..9b702e4f1 100644
--- a/tests/SerializeableTest.php
+++ b/tests/SerializeableTest.php
@@ -2,6 +2,7 @@
 
 
 use Spatie\LaravelData\DataCollection;
+use Spatie\LaravelData\Exceptions\CannotCreateData;
 use Spatie\LaravelData\Lazy;
 use Spatie\LaravelData\Support\Lazy\DefaultLazy;
 use Spatie\LaravelData\Tests\Fakes\LazyData;
@@ -9,6 +10,10 @@
 
 use function Spatie\Snapshots\assertMatchesSnapshot;
 
+beforeEach(function () {
+    ini_set('zend.exception_ignore_args', 'Off');
+});
+
 it('can serialize and unserialize a data object', function () {
     $object = SimpleData::from('Hello world');
 
@@ -83,3 +88,17 @@
     expect($unserialized)->toBeInstanceOf(LazyData::class);
     expect($unserialized->toArray())->toMatchArray(['name' => 'Hello world']);
 });
+
+it('can json_encode exception trace with args when not all required properties passed', function () {
+    // When zend.exception_ignore_args is set to Off, the trace will contain the arguments
+    // We want to make sure these all can be encoded into JSON
+
+    try {
+        SimpleData::from([]);
+    } catch (CannotCreateData $e) {
+        $trace = $e->getTrace();
+        $encodedJson = json_encode($trace, JSON_THROW_ON_ERROR);
+
+        expect($encodedJson)->toBeJson();
+    }
+});