GlideConversion unlink/copy in parallel process

[roylaveto]

There seems to be an issue with unlinking/copying files in a parallel process. We use Fastest to run our Behat tests, there are 16 processes running at the same time. They all create a file called avatar.png, but sometimes the temp file has already been unlinked by one of the other processes so it gives an error like this:
Warning: unlink(/tmp/c56e0ace46e8abb7bee0653bc32759c9): No such file or directory in vendor/spatie/image/src/GlideConversion.php
(Happens on line 129 and sometimes line 127. Might also be possible that it happens on line 78, but we don't use that function.)

It's just a warning and doesn't happen every time we run the tests (multiple times a day), but the test fails when given this warning sadly.

Here you can see it tries the unlink on the same file multiple times a second:

[2022-05-04 15:29:21] testing.INFO: removing save /tmp/233f5dbcb96e18d33a87e6068a487564  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/15e215c0dd08e76436dbe3b924354b34  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/c56e0ace46e8abb7bee0653bc32759c9  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/4e954f949528dc2f14cc202c1e484c2d  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/15e215c0dd08e76436dbe3b924354b34  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/c56e0ace46e8abb7bee0653bc32759c9  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/2911952670d782b6098ec6e3e38e6e1d  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/15e215c0dd08e76436dbe3b924354b34  
[2022-05-04 15:29:21] testing.INFO: removing save /tmp/c56e0ace46e8abb7bee0653bc32759c9 

Is it possible to add a check before unlinking or copying a file?

[freekmurze]

Feel free to PR this to the package!

[roylaveto]

@freekmurze Took some more time to test different methods and suppressing the copy/unlink isn't the best option either as when it tries to add the media the other process has already stolen/deleted the file and then the error happens when it tries to optimize the non-existing file.

So a few things that might work:

• Dependency injection of the Image class (the one with setTemporaryDirectory()), where we set the temporary directory to our number of test processes (1-16)
• Changing the avatar.png file to a unique name so it stores as a different temporary item
• Setting the temporary directory in the glide server (it has this option but can't be set?)

For now, I've changed the avatar name so it gives a different temporary item name but this is probably an anti-pattern as this should never happen.

I can't really make a PR since I don't know what option you'd prefer the most. I changed out the unlink for \File::delete() since this suppresses the error and gives back a boolean but then again it gives an error when optimizing the file.

So what would be the best option?

[freekmurze]

Let's investigate the first option firsts, that seems the cleanest to me in theory.