Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent correctness issues #996

Open
kornelski opened this issue Jan 13, 2017 · 0 comments
Open

User-Agent correctness issues #996

kornelski opened this issue Jan 13, 2017 · 0 comments

Comments

@kornelski
Copy link
Member

Sparkle's default user-agent contains app's name and version.

  • the app name can be non-ASCII (e.g. CFBundleDisplayName localized in Japanese). Cocoa replaces non-ASCII characters with ?, resulting in UA like ???????/1.0 Sparkle/1.15.

  • the app version is taken from displayVersion, which isn't the exact unique version of the build.

Those are small issues that affect collection of update statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kornelski