Skip to content

Commit fab4487

Browse files
authored
Merge pull request #46 from sparkfun/main
Pulling changes in main back to feature.
2 parents 0c4fc22 + fd205f8 commit fab4487

File tree

7 files changed

+7
-45
lines changed

7 files changed

+7
-45
lines changed

.github/workflows/compile-sketch.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
libraries: |
102102
- source-path: ./
103103
sketch-paths: |
104-
- tests
104+
- examples/Example_01_TestCompile
105105
enable-warnings-report: true
106106
enable-deltas-report: true
107107
verbose: true

README.md

+5-42
Original file line numberDiff line numberDiff line change
@@ -33,52 +33,15 @@ The SparkFun Toolkit provides a single implementation of common functionality us
3333

3434
Implemented using C++, the SparkFun toolkit follows a simple two layered approach in it's design: A core foundational layer, and a platform specific layer.
3535

36-
```mermaid
37-
---
38-
title: General Architecture Structure
39-
---
40-
classDiagram
41-
class CoreToolkit["Core Toolkit Interfaces"]
42-
class PlatformOne["Platform Implementation"]
43-
CoreToolkit <|-- PlatformOne
36+
![Core Architecture](docs/images/rm_img_01.png)
4437

45-
```
46-
And as additional plaforms are added, they also implement/inherit from the SparkFun Toolkit Core.
47-
```mermaid
48-
---
49-
title: Multi-Platform Structure
50-
---
51-
classDiagram
52-
class CoreToolkit["Core Toolkit Interfaces"]
53-
class PlatformOne["Platform One"]
54-
class PlatformTwo["Platform Two"]
55-
56-
CoreToolkit <|-- PlatformOne
57-
CoreToolkit <|-- PlatformTwo
58-
```
38+
And as additional platforms are added, they also implement/inherit from the SparkFun Toolkit Core.
5939

60-
When using the SparkFun Toolkit, the intent is for the implementation to follow the same pattern: A platform independent layer that works with the SparkFun Toolkit core, and a platform specific layer that utilizes the SparkFun Toolkit platform specific implementation.
40+
![Multi-Platform Structure](docs/images/rm_img_02.png)
6141

62-
```mermaid
63-
---
64-
title: Application Structure
65-
---
66-
classDiagram
67-
direction TD
68-
note for ApplicationCore "Application Logic"
69-
class ApplicationCore["Application Core"]
70-
class CoreToolkit["Core Toolkit Interfaces"]
71-
72-
note for CoreToolkit "SparkFun Toolkit"
73-
class ApplicationPlatform["Application Platform"]
74-
style ApplicationPlatform fill:#909090
75-
class PlatformOne["Platform Implementation"]
76-
style PlatformOne fill:#909090
77-
78-
CoreToolkit <|-- PlatformOne
79-
ApplicationCore <--> Application Platform
42+
When using the SparkFun Toolkit, the intent is for the implementation to follow the same pattern: A platform independent layer that works with the SparkFun Toolkit core, and a platform specific layer that utilizes the SparkFun Toolkit platform specific implementation.
8043

81-
```
44+
![Application Structure](docs/images/rm_img_03.png)
8245

8346
If/when the application is moved to another platform, just the platform specific logic needs implementation.
8447

docs/images/rm_img_01.png

68.3 KB
Loading

docs/images/rm_img_02.png

71.6 KB
Loading

docs/images/rm_img_03.png

95.7 KB
Loading

src/sfTkArdUART.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#pragma once
1515

16-
#include <cstddef>
1716
#include <memory>
1817

1918
#include <Arduino.h>
@@ -138,7 +137,7 @@ class sfTkArdUART : public sfTkIUART
138137
*
139138
* @retval ksftkErrOk on successful execution.
140139
*/
141-
sfTkError_t init(arduino::HardwareSerial &hwSerial, UARTConfig_t config, bool bInit = false);
140+
sfTkError_t init(arduino::HardwareSerial &hwSerial, sfTkIUART::UARTConfig_t &config, bool bInit = false);
142141

143142
/**
144143
* @brief Write `len` bytes to the UART TX buffer.

0 commit comments

Comments
 (0)