Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of non-JSON responses #139

Open
bhornseth opened this issue Oct 25, 2017 · 0 comments · May be fixed by #153
Open

Improve handling of non-JSON responses #139

bhornseth opened this issue Oct 25, 2017 · 0 comments · May be fixed by #153
Milestone
2.0

Comments

@bhornseth
Copy link
Member

Occassionally, the API (or more likely: the load balancer) will return anon-JSON response and we're handling that poorly:

MultiJson::ParseError lexical error: invalid char in json text.
                                       <h1>This website is under heavy
                     (right here) ------^
  
  /home/httpd/mls_search/prod/shared/bundle/ruby/2.3.0/gems/multi_json-1.12.1/lib/multi_json/adapters/yajl.rb:11:in `parse'
  /home/httpd/mls_search/prod/shared/bundle/ruby/2.3.0/gems/multi_json-1.12.1/lib/multi_json/adapters/yajl.rb:11:in `load'
  /home/httpd/mls_search/prod/shared/bundle/ruby/2.3.0/gems/multi_json-1.12.1/lib/multi_json/adapter.rb:21:in `load'
  /home/httpd/mls_search/prod/shared/bundle/ruby/2.3.0/gems/multi_json-1.12.1/lib/multi_json.rb:122:in `load'
  /home/httpd/mls_search/prod/shared/bundle/ruby/2.3.0/gems/spark_api-1.4.13/lib/spark_api/faraday_middleware.rb:20:in `on_complete'
@bhornseth bhornseth added this to the 2.0 milestone Oct 25, 2017
This was referenced Feb 15, 2019
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

WIP: v2 changes sparkapi/spark_api
1 participant
@bhornseth