Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing maintainer not notified on PR #86

Open
adamjstewart opened this issue May 28, 2023 · 2 comments
Open

Missing maintainer not notified on PR #86

adamjstewart opened this issue May 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@adamjstewart
Copy link
Member

spack/spack#37895 modifies the py-mdanalysis package, which @RMeli maintains. However, his review was not requested by spackbot, although many other maintainers were. This seems like a bug in our maintainer detection.
@adamjstewart adamjstewart added the bug Something isn't working label May 28, 2023
@RMeli
Copy link
Member

RMeli commented May 28, 2023

Is there a limit on the numbers of reviewers per PR?

@adamjstewart
Copy link
Member Author

Yes. If a PR has over 100 reviewers, spackbot doesn't notify any maintainers. If it has less than 100 reviewers, it should request all reviews. GitHub also has an internal limit, which I believe is also 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RMeli @adamjstewart