Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR changing maintainers should notify original maintainers only #41

Open
haampie opened this issue Aug 2, 2021 · 2 comments
Open

PR changing maintainers should notify original maintainers only #41

haampie opened this issue Aug 2, 2021 · 2 comments

Comments

@haampie
Copy link
Member

haampie commented Aug 2, 2021

spack/spack#25156 (comment)

  • The list of maintainers should be queried from the develop branch, not the PR itself.
  • When there were no maintainers previously and the PR adds new maintainers, the bot shouldn't comment at all.
@adamjstewart
Copy link
Member

I disagree, the PR should ping both new and old maintainers. Consider this situation. Someone adds the developer of the software library as a maintainer of the recipe without their consent. We want them to know about this so they aren't being notified out of the blue on future PRs.

@alecbcs
Copy link
Member

alecbcs commented Jun 30, 2023

I think I agree with @adamjstewart it'd be jarring to have someone add you to a package as maintainer without your acknowledgment.

@haampie do you agree with this assessment or are we overlooking something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants