Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up unused arrays #277

Closed
wants to merge 3 commits into from
Closed

clean up unused arrays #277

wants to merge 3 commits into from

Conversation

tapastro
Copy link
Collaborator

Partially addresses JP-3697

This PR addresses high memory usage in jump step by deleting some large arrays after use, and moving initialization of other arrays to the time at which they are needed.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@tapastro tapastro requested a review from a team as a code owner July 31, 2024 11:58
@github-actions github-actions bot added the jump label Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (2112773) to head (e7400b6).
Report is 69 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   84.32%   82.84%   -1.49%     
==========================================
  Files          41       41              
  Lines        7529     7531       +2     
==========================================
- Hits         6349     6239     -110     
- Misses       1180     1292     +112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

penaguerrero
penaguerrero requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@penaguerrero penaguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for this! I recommend moving the comment (lines 193 -195) as well for completeness.

@tapastro tapastro marked this pull request as draft September 5, 2024 16:06
@tapastro
Copy link
Collaborator Author

Closing this - it appears that this breaks code in unexpected ways, and I don't have the time to tackle the full refactor.

@tapastro tapastro closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penaguerrero penaguerrero penaguerrero requested changes

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

Assignees
No one assigned
Labels
jump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapastro @penaguerrero @kmacdonald-stsci