We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonarqube
bugs found by sonar scan: https://plsonarqube.stsci.edu/project/issues?resolved=false&types=BUG&id=spacetelescope-regresstiontests&open=AY1_N9SAz6SXJ5XqzbxH
romancal/romancal/associations/lib/rules_level2.py
Line 153 in 7a62ff3
Remove or refactor this statement; it has no side effects.
Should this be =?
=
romancal/romancal/pipeline/exposure_pipeline.py
Line 195 in 7a62ff3
same as 1; should this be =?
romancal/romancal/skymatch/region.py
Line 40 in 7a62ff3
Remove 1 parameters. Method __contains__ should have 2 parameters.
__contains__
will this raise an error if a user calls in, even before the NotImplementedError?
in
NotImplementedError
romancal/romancal/tests/base_classes.py
Line 105 in 7a62ff3
path is used before it is defined. Move the definition before.
path
The text was updated successfully, but these errors were encountered:
Issues 1, 2, and 4 could be caught by ruff if we include the right rule sets. I'll see if I can find those.
Sorry, something went wrong.
Issues 1 and 2 should be caught by B015 (and/or B018).
Issue 4 might be caught by F821.
It is possible that even issue 3 might be caught but I don't see a rule when I glanced through: https://docs.astral.sh/ruff/rules/ that might apply.
In any case I suggest we explicitly turn on Pyflakes (F) and Bugbear (B), fixing all the issues they find as those are both recommended rule sets.
F
B
Successfully merging a pull request may close this issue.
bugs found by sonar scan:
https://plsonarqube.stsci.edu/project/issues?resolved=false&types=BUG&id=spacetelescope-regresstiontests&open=AY1_N9SAz6SXJ5XqzbxH
romancal/romancal/associations/lib/rules_level2.py
Line 153 in 7a62ff3
Should this be
=
?romancal/romancal/pipeline/exposure_pipeline.py
Line 195 in 7a62ff3
same as 1; should this be
=
?romancal/romancal/skymatch/region.py
Line 40 in 7a62ff3
will this raise an error if a user calls
in
, even before theNotImplementedError
?romancal/romancal/tests/base_classes.py
Line 105 in 7a62ff3
The text was updated successfully, but these errors were encountered: