Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up linting #521

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR cleans up the linting in RAD, so that ruff is used over other tools performing the same function.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 27, 2024 16:40
@WilliamJamieson WilliamJamieson requested review from zacharyburnett and removed request for a team November 27, 2024 16:40
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (f92cfab) to head (b5428c3).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_schemas.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   95.81%   96.24%   +0.43%     
==========================================
  Files           4        4              
  Lines         215      213       -2     
==========================================
- Hits          206      205       -1     
+ Misses          9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson merged commit a90fb37 into spacetelescope:main Dec 2, 2024
13 of 14 checks passed
@WilliamJamieson WilliamJamieson deleted the mnt/clean_up_lint branch December 2, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants