Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Python 2.x items #262

Closed
7 tasks done
mperrin opened this issue Aug 27, 2018 · 5 comments
Closed
7 tasks done

Remove all Python 2.x items #262

mperrin opened this issue Aug 27, 2018 · 5 comments
Assignees
Milestone

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 27, 2018

Issue by mperrin
Thursday Aug 16, 2018 at 01:21 GMT
Originally opened as mperrin/poppy#262


Borrowing from the to-do list at astropy/astropy#6234

  • Remove __future__ imports
  • Make sure we remove the unicode_literals text fixture
  • Search for and remove any 'six' imports and in some cases replace by the appropriate Python 3 import.
  • Search for and remove any if six.PY2 blocks and also search for sys.version_info or any usage of minversion or Looseversion.
  • Update CI configuration to not run tests on Python 2
  • Search for comments that mention Python (either 2 or 3 or none of them) to see if anything can be updated
  • Remove python2 related info from the documentation
@mperrin
Copy link
Collaborator Author

mperrin commented Aug 27, 2018

Comment by mperrin
Thursday Aug 16, 2018 at 01:22 GMT


also

  • remove the back ported version of lru_cache in the vendor directory.

@mperrin
Copy link
Collaborator Author

mperrin commented Aug 27, 2018

Comment by mperrin
Thursday Aug 16, 2018 at 01:25 GMT


and update the documentation and setup config to enforce a minimum Python version of 3.4.

mperrin added a commit that referenced this issue Aug 27, 2018
@mperrin mperrin self-assigned this Aug 29, 2018
@mperrin mperrin added this to the 0.8.0 milestone Aug 29, 2018
@mperrin
Copy link
Collaborator Author

mperrin commented Sep 18, 2018

Min version 3.5 (same as astropy currently) enforcement added in 83ba201

@mperrin
Copy link
Collaborator Author

mperrin commented Sep 18, 2018

  • remove from __future__ imports

@mperrin
Copy link
Collaborator Author

mperrin commented Nov 28, 2018

Found one more Py2-ism in the testing code, which gets removed in #264. Other than that, this code all appears thoroughly de-python-2'ed at this point. I think it's sufficient for this issue to be considered closed.

@mperrin mperrin closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant