Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AnalyticOptic.to_fits() for complex type #153

Closed
mperrin opened this issue Aug 23, 2018 · 1 comment
Closed

fix AnalyticOptic.to_fits() for complex type #153

mperrin opened this issue Aug 23, 2018 · 1 comment
Labels
bug Something isn't working priority:low

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 23, 2018

Issue by mperrin
Wednesday Feb 10, 2016 at 19:11 GMT
Originally opened as mperrin/poppy#153

Can't store complex numbers in FITS files natively so the following fails.

optic = optics.ThinLens(radius=1)
fitsfile = optic.to_fits(npix=512, what='complex')

Fix should probably be to pull out the real and imaginary parts, and save them as 2 slices of a data cube, with appropriate FITS headers to indicate such.

Leaving this for later, not release 0.4.1 immanently. Low priority.
@mperrin mperrin added bug Something isn't working priority:low labels Aug 23, 2018
@mperrin
Copy link
Collaborator Author

mperrin commented Aug 12, 2019

This was fixed in #293

@mperrin mperrin closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperrin