You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be useful to consolidate these by making jwst inherit the relevant functions from photutils. This would make it so we no longer need to maintain this in two places, and so that both repositories would benefit from any bug fixes or improvements.
In particular, the following function pairs appear to do the same thing (listed JWST first, photutils second):
_daofind_cutout and cutout_data
_daofind_cutout_conv and cutout_convdata
roundness and roundness1
sharpness and sharpness
There may be others.
It might also be possible to replace the _aper_local_background function with functionality from photutils.background, and rely on astropy more heavily for various flux conversions.
The text was updated successfully, but these errors were encountered:
Issue JP-3866 was created on JIRA by Ned Molter:
The JWSTSourceCatalog object in source_catalog.source_catalog.py has quite a bit of code that appears to duplicate photutils.detection.daofinder.py (see https://github.com/astropy/photutils/blob/main/photutils/detection/daofinder.py ).](https://github.com/astropy/photutils/blob/main/photutils/detection/daofinder.py).)
It would be useful to consolidate these by making jwst inherit the relevant functions from photutils. This would make it so we no longer need to maintain this in two places, and so that both repositories would benefit from any bug fixes or improvements.
In particular, the following function pairs appear to do the same thing (listed JWST first, photutils second):
_daofind_cutout
andcutout_data
_daofind_cutout_conv
andcutout_convdata
roundness
androundness1
sharpness
andsharpness
There may be others.
It might also be possible to replace the
_aper_local_background
function with functionality from photutils.background, and rely on astropy more heavily for various flux conversions.The text was updated successfully, but these errors were encountered: