Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints in jwst code #8794

Closed
stscijgbot-jp opened this issue Sep 17, 2024 · 1 comment · Fixed by #8852
Closed

Fix type hints in jwst code #8794

stscijgbot-jp opened this issue Sep 17, 2024 · 1 comment · Fixed by #8852
Labels
Software Affected: extract_1d team-chartreuse

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3749 was created on JIRA by Melanie Clarke:

Typing hints in extract.py are out of date and need to be either updated or removed.

We should also consider adding a mypy check to CI for the jwst repo, to verify that any included typing hints are correct and up to date.  The stcal repo already performs a similar check.
@emolter emolter mentioned this issue Oct 2, 2024
Merged
12 tasks
@stscijgbot-jp
Copy link
Collaborator Author

Comment by Ned Molter on JIRA:

Fixed by #8852 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Software Affected: extract_1d team-chartreuse
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JP-3749: Add mypy type checking emolter/jwst
1 participant
@stscijgbot-jp